Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildah: 0.12 -> 1.1 #43197

Merged
merged 1 commit into from Jul 11, 2018
Merged

buildah: 0.12 -> 1.1 #43197

merged 1 commit into from Jul 11, 2018

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Jul 8, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member Author

nlewo commented Jul 8, 2018

@GrahamcOfBorg build buildah

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: buildah

Partial log (click to expand)

/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/validate/govet.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/validate/gometalinter.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/validate/gofmt.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/validate/git-validation.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/examples/copy.sh: interpreter directive changed from "/bin/bash -x" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -x"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/examples/all-the-things.sh: interpreter directive changed from "/bin/bash -x" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -x"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/examples/lighttpd.sh: interpreter directive changed from "/bin/bash -x" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -x"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/selinux_tag.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /tmp/nix-build-buildah-1.1.drv-0 in /nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1...
/nix/store/abgp2dw4n3xzcd8mrga14xdwxy8pbdp2-buildah-1.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: buildah

Partial log (click to expand)

/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/examples/lighttpd.sh: interpreter directive changed from "/bin/bash -x" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -x"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/.papr.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/test_buildah_build_rpm.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/test_runner.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/validate/govet.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/validate/git-validation.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/validate/gometalinter.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1/share/go/src/github.com/projectatomic/buildah/tests/validate/gofmt.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/wwxfj69wfkni7dijw4442pq2hmwx6w64-buildah-1.1...
/nix/store/abgp2dw4n3xzcd8mrga14xdwxy8pbdp2-buildah-1.1-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: buildah

Partial log (click to expand)

copying path '/nix/store/6rnvk9vcywcxingz5h6wnlv3mv54bib9-go-md2man-1.0.6-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/6zd40ii99f9wgl986n9nv3dkld48agxr-govers-20150109-3b5f175-bin' from 'https://cache.nixos.org'...
acquiring/releasing lock: Resource deadlock avoided
acquiring/releasing lock: Resource deadlock avoided
acquiring/releasing lock: Resource deadlock avoided
acquiring/releasing lock: Resource deadlock avoided
acquiring/releasing lock: Resource deadlock avoided
copying path '/nix/store/qxhz6hdvxxx6ls8spi5c2v6y7h0zjjby-govers-20150109-3b5f175' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/xqrmhqpd8v0hiir29hlzj6l3l3nb3i0d-buildah-1.1.drv': 8 dependencies couldn't be built
error: build of '/nix/store/xqrmhqpd8v0hiir29hlzj6l3l3nb3i0d-buildah-1.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: buildah

Partial log (click to expand)

trying https://github.com/projectatomic/buildah/archive/v1.1.tar.gz
copying path '/nix/store/386h84i8rwa5xhkfc88x5wyz3bb98xc8-lvm2-2.02.177' from 'https://cache.nixos.org'...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   127    0   127    0     0   1104      0 --:--:-- --:--:-- --:--:--  1104
copying path '/nix/store/nw6783r7505s83dw5c9d3v9gp28i3n12-go-1.10.3' from 'https://cache.nixos.org'...
100 4154k    0 4154k    0     0  3493k      0 --:--:--  0:00:01 --:--:-- 20.0M
unpacking source archive /build/v1.1.tar.gz
cannot build derivation '/nix/store/xqrmhqpd8v0hiir29hlzj6l3l3nb3i0d-buildah-1.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/xqrmhqpd8v0hiir29hlzj6l3l3nb3i0d-buildah-1.1.drv' failed

@xeji
Copy link
Contributor

xeji commented Jul 10, 2018

cc @Profpatsch

@nlewo
Copy link
Member Author

nlewo commented Jul 10, 2018

The failure on aarch84-linux doesn't seem to be related to this patch.

@Profpatsch
Copy link
Member

Oh wow, they just put the first line of commit messages as their “changelog”. m(

Other than that, I think we can merge.

@Profpatsch Profpatsch merged commit 8e98630 into NixOS:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlewo @GrahamcOfBorg @xeji @Profpatsch