Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.72.1 -> 0.73.0 #43153

Merged
merged 1 commit into from Jul 9, 2018
Merged

home-assistant: 0.72.1 -> 0.73.0 #43153

merged 1 commit into from Jul 9, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

https://www.home-assistant.io/blog/2018/07/06/release-73/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @peterhoeg

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

tests/components/test_init.py ................                           [ 71%]
tests/components/test_introduction.py .                                  [ 71%]
tests/components/test_logger.py ......                                   [ 74%]
tests/components/test_script.py .....                                    [ 77%]
tests/components/test_shell_command.py ........                          [ 81%]
tests/components/test_system_log.py ................                     [ 90%]
tests/components/test_websocket_api.py ..................                [100%]

========================= 187 passed in 23.18 seconds ==========================
/nix/store/xphfnza6xzz5pjcmgm7pm90z3dzcbm2d-homeassistant-0.73.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

tests/components/test_init.py ................                           [ 71%]
tests/components/test_introduction.py .                                  [ 71%]
tests/components/test_logger.py ......                                   [ 74%]
tests/components/test_script.py .....                                    [ 77%]
tests/components/test_shell_command.py ........                          [ 81%]
tests/components/test_system_log.py ................                     [ 90%]
tests/components/test_websocket_api.py ..................                [100%]

========================== 187 passed in 5.91 seconds ==========================
/nix/store/gs1ca7j3mhnfr6idra72zvxi73wcshlq-homeassistant-0.73.0

peterhoeg
peterhoeg reviewed Jul 8, 2018
View reviewed changes
pkgs/servers/home-assistant/frontend.nix

src = fetchPypi {
inherit pname version;
sha256 = "1kzz1cmnpmsnrbc9amjcg8rb4a544xx2mpq4g23si6rk46b7n0x7";
sha256 = "eb6c0f330e4320092de708750675e3e973038a8b05928734b71a38d5a3ee66cf";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the new hash longer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer using the base16 hash from PyPI because it can easily be checked for correctness.

@peterhoeg peterhoeg merged commit f759a0d into NixOS:master Jul 9, 2018
@dotlambda dotlambda deleted the home-assistant-0.73.0 branch March 21, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @GrahamcOfBorg @peterhoeg