Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] make RubyFixnum without (internal) cache working #5241

Merged
merged 1 commit into from
Jul 7, 2018
Merged

[fix] make RubyFixnum without (internal) cache working #5241

merged 1 commit into from
Jul 7, 2018

Conversation

kares
Copy link
Member

@kares kares commented Jul 7, 2018

JRuby was broken with -Xfixnum.cache=false, the static helpers such
as RubyFixnum.zero did assume the cache to be always there ...

... when running mvn -Ptest it didn't even boot properly :

java.lang.ArrayIndexOutOfBoundsException: 0
	at org.jruby.RubyFixnum.zero(RubyFixnum.java:220)
	at org.jruby.RubyComplex.createComplexClass(RubyComplex.java:111)
	at org.jruby.Ruby.initCore(Ruby.java:1480)
	at org.jruby.Ruby.bootstrap(Ruby.java:1318)
	at org.jruby.Ruby.init(Ruby.java:1217)
	at org.jruby.Ruby.newInstance(Ruby.java:362)
	at org.jruby.Ruby.newInstance(Ruby.java:350)

@kares
[fix] make RubyFixnum without (internal) cache working
9cc414b 
JRuby was broken with **-Xfixnum.cache=false**, the static helpers such
as `RubyFixnum.zero` did assume the cache to be always there ...
@kares
Copy link
Member Author

kares commented Jul 7, 2018

isn't really tested only run the suite manually - fix is trivial although might get forgotten at some point

@kares kares merged commit e0374d3 into master Jul 7, 2018
@kares kares deleted the fix-fixnum-cache branch July 7, 2018 09:08
@kares kares added this to the JRuby 9.2.1.0 milestone Jul 7, 2018
kares added a commit that referenced this pull request Jul 7, 2018
@kares
[fix] make RubyFixnum without (internal) cache working (#5241)
520e2a7 
JRuby was broken with **-Xfixnum.cache=false**, the static helpers such
as `RubyFixnum.zero` did assume the cache to be always there ...
@kares
Copy link
Member Author

kares commented Jul 7, 2018

back-ported to 9.1 520e2a7

@kares kares modified the milestones: JRuby 9.2.1.0, JRuby 9.1.18.0 Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.1.18.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kares