pythonPackages.dkimpy: 0.6.2 -> 0.8.1 #43219

leenaars · 2018-07-08T12:26:10Z

Motivation for this change

Bumped version. Packaged dependency (authres) as separate commit.
Note that dkimpy both serves as a library and contains a set of tools.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

dotlambda · 2018-07-08T13:19:31Z

Please also make all changes requested in #34980.

dotlambda · 2018-07-08T13:24:01Z

Is dkimpy both, an application and a library? If so you can keep it under pythonPackages but please reflect this in your commit message. In all-packages.nix, please use toPythonApplication.

dotlambda · 2018-07-08T13:26:36Z

Btw, CONTRIBUTING.md tells you to use init at, not init ->

dotlambda · 2018-07-08T14:05:06Z

pkgs/development/python-modules/authres/default.nix

+  pname = "authres";
+  version = "${majorversion}.${minorversion}";
+
+  src = fetchurl {


Any reason not to use fetchPypi?

No particular reason. This is the upstream/source. Of course pypi is mirrored, so if you want I can change.

Yes, please do. This will facilitate (semi-)automatic upgrades.

And it will allow us to get rid of majorversion and minorversion.

dotlambda · 2018-07-08T14:05:34Z

pkgs/development/python-modules/dkimpy/default.nix

-  majorversion = "0.6";
-  minorversion = "2";
+  majorversion = "0.8";
+  minorversion = "1";
 in buildPythonApplication rec {
  pname = "dkimpy";
  version = "${majorversion}.${minorversion}";

  src = fetchurl {


Any reason not to use fetchPypi?

dotlambda · 2018-07-08T14:06:18Z

pkgs/development/python-modules/dkimpy/default.nix

  };

  checkInputs = [ pytest ];
-  propagatedBuildInputs =  [ openssl dnspython ];
+  propagatedBuildInputs =  [ openssl dnspython pynacl authres ];


openssl is not needed here

My assumption was that since one of the tools (dknewkey) needs an openssl binary, this would have to be part of the path - and thus be a propagated input. Is that not the case?

If it's needed in the path, then one of the following solutions should be used:

Patch the path into the source code as you're doing it for dknewkey (preferred)

Use makeWrapper

So, if the substituteInPlace you're doing patches all places where openssl is called you should be fine and won't need openssl in *buildInputs.

But isn't it more robust to make it explicit that it needs this input? I can imagine some kind of future optimisation that creates minimal chroot environments with only the declared propagatedBuildInputs... There seems no harm in not having the very smallest closure if it is clearer for the future?

Yes, there is harm. You don't want any project using dkimpy to have openssl in its path. That should be made explicit.

propagatedBuildInputs should generally never be used. Sadly, for Python libraries there's currently no better solution.

dotlambda · 2018-07-08T14:06:44Z

pkgs/development/python-modules/dkimpy/default.nix

-  majorversion = "0.6";
-  minorversion = "2";
+  majorversion = "0.8";
+  minorversion = "1";
 in buildPythonApplication rec {


buildPythonPackage

dotlambda · 2018-07-08T14:10:41Z

pkgs/top-level/all-packages.nix

@@ -615,7 +615,7 @@ with pkgs;

  dgsh = callPackage ../shells/dgsh { };

-  dkimpy = pythonPackages.dkimpy;
+  dkimpy = with pythonPackages; toPythonApplication dkimpy;


dotlambda · 2018-07-08T14:11:25Z

Please still do use the pythonPackages prefix in the commit message.

dotlambda · 2018-07-08T14:12:50Z

pkgs/development/python-modules/dkimpy/default.nix

-    makeWrapper "$out/libexec/dkimsign.py" $out/bin/dkimsign
-    makeWrapper "$out/libexec/arcverify.py" $out/bin/arcverify
-    makeWrapper "$out/libexec/arcsign.py" $out/bin/arcsign
-    makeWrapper "$out/libexec/dknewkey.py" $out/bin/dknewkey


Don't you want to rename the executables any more?

Upstream is doing that for me...

dotlambda · 2018-07-08T15:00:18Z

@leenaars

Please still do use the pythonPackages prefix in the commit message.

dotlambda · 2018-07-08T15:01:08Z

@GrahamcOfBorg build python2.pkgs.authres python3.pkgs.authres
@GrahamcOfBorg build python2.pkgs.dkimpy python3.pkgs.dkimpy

GrahamcOfBorg · 2018-07-08T15:02:03Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.authres, python3.pkgs.authres

Partial log (click to expand)

/build/authres-1.1.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/914mkrhnmsyl4jymsr6aznfvbinmwlbf-python3.6-authres-1.1.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/914mkrhnmsyl4jymsr6aznfvbinmwlbf-python3.6-authres-1.1.0/lib
patching script interpreter paths in /nix/store/914mkrhnmsyl4jymsr6aznfvbinmwlbf-python3.6-authres-1.1.0
checking for references to /build in /nix/store/914mkrhnmsyl4jymsr6aznfvbinmwlbf-python3.6-authres-1.1.0...
running install tests
/nix/store/prm3haaazarl0im0gs10ldsq0ydpka2a-python2.7-authres-1.1.0
/nix/store/914mkrhnmsyl4jymsr6aznfvbinmwlbf-python3.6-authres-1.1.0

GrahamcOfBorg · 2018-07-08T15:02:17Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.dkimpy, python3.pkgs.dkimpy

Partial log (click to expand)

Ran 82 tests in 0.667s

OK
.
----------------------------------------------------------------------
Ran 1 test in 0.028s

OK
/nix/store/3d5iqfl2f0kwrxxqxy9qxaszwhd57vg9-python2.7-dkimpy-0.8.1
/nix/store/kfb6iq6mf27mf1asads85b1xg7f1ych7-python3.6-dkimpy-0.8.1

GrahamcOfBorg · 2018-07-08T15:05:20Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.authres, python3.pkgs.authres

Partial log (click to expand)

these derivations will be built:
  /nix/store/1qwa5psd037wiwnnwdap9p73skz7cvz0-authres-1.1.0.tar.gz.drv
  /nix/store/g2ivdz0lcs6w260y10ca08kki948q94i-python3.6-authres-1.1.0.drv
  /nix/store/nwi8cwhd1p58r5zcqanqq6iv7dfl6485-python2.7-authres-1.1.0.drv
these paths will be fetched (1.00 MiB download, 5.78 MiB unpacked):
  /nix/store/9w0kf0iw7ky3ri67nslsdnxnjr13b4yp-python2.7-bootstrapped-pip-10.0.1
copying path '/nix/store/9w0kf0iw7ky3ri67nslsdnxnjr13b4yp-python2.7-bootstrapped-pip-10.0.1' from 'https://cache.nixos.org'...
waiting for locks or build slots...
/nix/store/7wf8hq8020wby8wvnmszy9vpwxp3a306-python2.7-authres-1.1.0
/nix/store/zmxh3ndcbqknizz2cdypm5vzixjrfdz4-python3.6-authres-1.1.0

GrahamcOfBorg · 2018-07-08T15:05:32Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.dkimpy, python3.pkgs.dkimpy

Partial log (click to expand)

Ran 82 tests in 0.969s

OK
.
----------------------------------------------------------------------
Ran 1 test in 0.039s

OK
/nix/store/ncpijw53ab49vc2rdzkipjacakp6lyrm-python2.7-dkimpy-0.8.1
/nix/store/mdbzxs6ih40a9lhcy2pvwsl1sx1lpjdd-python3.6-dkimpy-0.8.1

leenaars requested a review from FRidh as a code owner July 8, 2018 12:26

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 8, 2018

dotlambda mentioned this pull request Jul 8, 2018

pythonPackages.dkimpy: 0.6.2 -> 0.7.1 #34980

Closed

8 tasks

dotlambda changed the title ~~(pythonPackages.)dkimpy: 0.6.2 -> 0.8.1~~ pythonPackages.dkimpy: 0.6.2 -> 0.8.1 Jul 8, 2018

leenaars force-pushed the dkimpy branch from 73b8a05 to 75792af Compare July 8, 2018 14:04

dotlambda reviewed Jul 8, 2018

View reviewed changes

leenaars force-pushed the dkimpy branch from 75792af to 9f44889 Compare July 8, 2018 14:09

dotlambda reviewed Jul 8, 2018

View reviewed changes

leenaars force-pushed the dkimpy branch from 9f44889 to 8e30d87 Compare July 8, 2018 14:21

pythonPackages.authres: init at 1.1.0

eece903

leenaars force-pushed the dkimpy branch from 8e30d87 to d708501 Compare July 8, 2018 14:28

pythonPackages.dkimpy: 0.6.2 -> 0.8.1

268cef2

dotlambda force-pushed the dkimpy branch from d708501 to 268cef2 Compare July 8, 2018 15:33

dotlambda merged commit 2a8a553 into NixOS:master Jul 8, 2018

GrahamcOfBorg removed the 6.topic: python label Jul 8, 2018

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.dkimpy: 0.6.2 -> 0.8.1 #43219

pythonPackages.dkimpy: 0.6.2 -> 0.8.1 #43219

leenaars commented Jul 8, 2018 •

edited

dotlambda commented Jul 8, 2018

dotlambda commented Jul 8, 2018

dotlambda commented Jul 8, 2018

dotlambda Jul 8, 2018

leenaars Jul 8, 2018

dotlambda Jul 8, 2018

dotlambda Jul 8, 2018

dotlambda Jul 8, 2018

dotlambda Jul 8, 2018

leenaars Jul 8, 2018

dotlambda Jul 8, 2018 •

edited

leenaars Jul 8, 2018

dotlambda Jul 8, 2018 •

edited

dotlambda Jul 8, 2018

dotlambda Jul 8, 2018

dotlambda Jul 8, 2018

dotlambda commented Jul 8, 2018

dotlambda Jul 8, 2018 •

edited

leenaars Jul 8, 2018

dotlambda Jul 8, 2018

dotlambda commented Jul 8, 2018 •

edited

dotlambda commented Jul 8, 2018

GrahamcOfBorg commented Jul 8, 2018

GrahamcOfBorg commented Jul 8, 2018

GrahamcOfBorg commented Jul 8, 2018

GrahamcOfBorg commented Jul 8, 2018

pythonPackages.dkimpy: 0.6.2 -> 0.8.1 #43219

pythonPackages.dkimpy: 0.6.2 -> 0.8.1 #43219

Conversation

leenaars commented Jul 8, 2018 • edited

Motivation for this change

Things done

dotlambda commented Jul 8, 2018

dotlambda commented Jul 8, 2018

dotlambda commented Jul 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda Jul 8, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda Jul 8, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Jul 8, 2018

dotlambda Jul 8, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Jul 8, 2018 • edited

dotlambda commented Jul 8, 2018

GrahamcOfBorg commented Jul 8, 2018

GrahamcOfBorg commented Jul 8, 2018

GrahamcOfBorg commented Jul 8, 2018

GrahamcOfBorg commented Jul 8, 2018

leenaars commented Jul 8, 2018 •

edited

dotlambda Jul 8, 2018 •

edited

dotlambda Jul 8, 2018 •

edited

dotlambda Jul 8, 2018 •

edited

dotlambda commented Jul 8, 2018 •

edited