Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nyx: init at 2.0.4 #43139

Merged
merged 1 commit into from Jul 7, 2018
Merged

nyx: init at 2.0.4 #43139

merged 1 commit into from Jul 7, 2018

Conversation

offlinehacker
Copy link
Contributor

No description provided.

@offlinehacker offlinehacker requested a review from FRidh as a code owner July 7, 2018 09:56
dotlambda
dotlambda requested changes Jul 7, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nyx is an appllication and should not live under pythonPackages. You should also use buildPythonApplication.

@offlinehacker
Copy link
Contributor Author

@dotlambda should be fixed now, thanks! It was some time ago, i last packaged python app in nixos, i can see a few things has changed on better since then, :)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nyx

Partial log (click to expand)

warning: no previously-included files matching '*.swo' found anywhere in distribution
warning: no previously-included files matching '*~' found anywhere in distribution
writing manifest file 'nyx.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/d8g1bl1hqgcpb5xi0dahqy9hq9kwqxdx-nyx-2.0.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nyx

Partial log (click to expand)

warning: no previously-included files matching '*.swo' found anywhere in distribution
warning: no previously-included files matching '*~' found anywhere in distribution
writing manifest file 'nyx.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/1rkgs81293hx8swcij38wrqp4n392x2w-nyx-2.0.4

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

You can try to add something like

checkPhase = ''
  ./run_tests.py
'';

If you don't get the tests to work, please set doCheck = false and add a comment why.

@offlinehacker
Copy link
Contributor Author

I did not manage to get tests working, also i did not spend too much time to try, but i wrote a comment about error that test suite reports and it seems to be super error in code. I explicitly disabled tests with noCheck = true;

@dotlambda
Copy link
Member

@GrahamcOfBorg build nyx

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nyx

Partial log (click to expand)

Successfully installed nyx-2.0.4
/build/nyx-2.0.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4/lib  /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4/bin
patching script interpreter paths in /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4
checking for references to /build in /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4...
wrapping `/nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4/bin/nyx'...
/nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nyx

Partial log (click to expand)

Successfully installed nyx-2.0.4
/build/nyx-2.0.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/midx319llvzxkaxs4i1gj5kga1dgz766-nyx-2.0.4
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/midx319llvzxkaxs4i1gj5kga1dgz766-nyx-2.0.4/lib  /nix/store/midx319llvzxkaxs4i1gj5kga1dgz766-nyx-2.0.4/bin
patching script interpreter paths in /nix/store/midx319llvzxkaxs4i1gj5kga1dgz766-nyx-2.0.4
checking for references to /build in /nix/store/midx319llvzxkaxs4i1gj5kga1dgz766-nyx-2.0.4...
wrapping `/nix/store/midx319llvzxkaxs4i1gj5kga1dgz766-nyx-2.0.4/bin/nyx'...
/nix/store/midx319llvzxkaxs4i1gj5kga1dgz766-nyx-2.0.4

@dotlambda dotlambda merged commit 499203e into NixOS:master Jul 7, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nyx

Partial log (click to expand)

/nix/store/midx319llvzxkaxs4i1gj5kga1dgz766-nyx-2.0.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nyx

Partial log (click to expand)

Successfully installed nyx-2.0.4
/build/nyx-2.0.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4/lib  /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4/bin
patching script interpreter paths in /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4
checking for references to /build in /nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4...
wrapping `/nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4/bin/nyx'...
/nix/store/4rybky4xnwmdw22nysw4251kp7d96sc1-nyx-2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@offlinehacker @GrahamcOfBorg @dotlambda