Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bliss: fix header location #43170

Merged
merged 2 commits into from Jul 16, 2018
Merged

bliss: fix header location #43170

merged 2 commits into from Jul 16, 2018

Conversation

fragamus
Copy link
Contributor

@fragamus fragamus commented Jul 8, 2018

Motivation for this change

In order to be detected automatically, the bliss include directory is expected by dependent packages (scipoptsuite) to have a certain structure which is imposed by the present commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fpletz fpletz changed the title Bliss detect bliss: fix header location Jul 16, 2018
@fpletz
Copy link
Member

fpletz commented Jul 16, 2018

@GrahamcOfBorg build bliss scipoptsuite

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bliss, scipoptsuite

Partial log (click to expand)

in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Cannot nix-instantiate `scipoptsuite' because:
error: attribute 'scipoptsuite' in selection path 'scipoptsuite' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bliss, scipoptsuite

Partial log (click to expand)

in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Cannot nix-instantiate `scipoptsuite' because:
�[31;1merror:�[0m attribute 'scipoptsuite' in selection path 'scipoptsuite' not found

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bliss

The following builds were skipped because they don't evaluate on x86_64-linux: scipoptsuite

Partial log (click to expand)

g++ -I. -g -Wall --pedantic -O9 -fPIC -o bliss bliss.o defs.o graph.o partition.o orbit.o uintseqhash.o heap.o timer.o utils.o bliss_C.o 
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cymi9fh3v81mrx8rpkn3j3168nbcrf4v-bliss-0.73
shrinking /nix/store/cymi9fh3v81mrx8rpkn3j3168nbcrf4v-bliss-0.73/bin/bliss
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cymi9fh3v81mrx8rpkn3j3168nbcrf4v-bliss-0.73/lib  /nix/store/cymi9fh3v81mrx8rpkn3j3168nbcrf4v-bliss-0.73/bin 
patching script interpreter paths in /nix/store/cymi9fh3v81mrx8rpkn3j3168nbcrf4v-bliss-0.73
checking for references to /tmp/nix-build-bliss-0.73.drv-0 in /nix/store/cymi9fh3v81mrx8rpkn3j3168nbcrf4v-bliss-0.73...
/nix/store/cymi9fh3v81mrx8rpkn3j3168nbcrf4v-bliss-0.73

@fpletz fpletz merged commit 794a60a into NixOS:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fragamus @fpletz @GrahamcOfBorg