gsignond: init at 1.0.7 #43133

worldofpeace · 2018-07-07T02:16:22Z

Motivation for this change

Needed this for elementary packaging.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

worldofpeace · 2018-07-07T05:28:41Z

It seems there's also some plugins that I also need that want to be installed at like gsignond/gplugins/libsasl.so
Here is https://gitlab.com/accounts-sso/gsignond-plugin-sasl

jtojnar · 2018-07-07T10:36:07Z

pkgs/development/libraries/gsignond/default.nix

+
+  postPatch = ''
+    substituteInPlace meson.build \
+    --replace "sysconf_dir = '/etc'" "sysconf_dir = 'etc/'"


I think this will not work, since the path is used in the code to find the configuration (GSIGNOND_SYSCONF_DIR). You need to patch just this line. Also patch files are better than seding, since it makes sure the replacement still works.

Thought as much and @samueldr did to.

jtojnar · 2018-07-07T10:36:23Z

pkgs/development/libraries/gsignond/default.nix

+    maintainers = with maintainers; [ worldofpeace ];
+    platforms = platforms.linux;
+  };
+}


Missing trailing newline.

jtojnar · 2018-07-07T10:36:47Z

pkgs/development/libraries/gsignond/default.nix

+  '';
+
+  meta = with stdenv.lib; {
+    description = "a D-Bus service which performs user authentication on behalf of it's clients";


probably can drop the initial a, it's → its

jtojnar · 2018-07-07T10:38:04Z

pkgs/development/libraries/gsignond/default.nix

+
+  mesonFlags = [
+    # Building documentation does not work in sandboxed environments
+    "-D documentation=false"


should not have the space.

Actually, gtk-doc docbook_xsl docbook_xml_dtd_43 docbook_xml_dtd_45 should be enough to build the documentation.

Ah I see, I'll add them.

You will also need to add glibcLocales to nativeBuildInputs and LC_ALL = "en_US.UTF-8"; to the attribute to prevent weird encoding error during docs build.

hah I just saw that errors and was going to do exactly that.

jtojnar · 2018-07-07T10:40:05Z

pkgs/development/libraries/gsignond/default.nix

+  meta = with stdenv.lib; {
+    description = "a D-Bus service which performs user authentication on behalf of it's clients";
+    homepage = https://gitlab.com/accounts-sso/gsignond;
+    license = licenses.lgpl2;


This should be lgpl21Plus: https://gitlab.com/accounts-sso/gsignond/blob/44e1e3dca19ece7f35ed6ee8c9cfbd7767003dbb/src/daemon/main.c#L13

jtojnar · 2018-07-07T10:46:40Z

pkgs/development/libraries/gsignond/default.nix

+    sha256 = "03a9d92hldav18bhx63kgi88li8fnm56337bjsr7391awq1k9mv7";
+  };
+
+  nativeBuildInputs = [ pkgconfig meson ninja gobjectIntrospection vala_0_34 ];


Just vala works for me.

pkgs/development/libraries/gsignond/default.nix

+  version = "1.0.7";
+
+  name = "${pname}-${version}";
+


worldofpeace · 2018-07-07T10:53:28Z

pkgs/development/libraries/gsignond/default.nix

@@ -0,0 +1,37 @@
+{ stdenv, fetchFromGitLab, pkgconfig, meson, ninja, glib, glib-networking, sqlite, gobjectIntrospection, vala }:


@jtojnar This builds with just regular vala.

jtojnar · 2018-07-07T12:28:39Z

pkgs/development/libraries/libgsignon-glib/default.nix

+
+  configureFlags = [
+    "--enable-introspection=yes"
+    "--disable-static"


Do we need a static library?

pkgs/development/libraries/libgsignon-glib/default.nix

jtojnar · 2018-07-07T14:01:40Z

pkgs/development/libraries/libgsignon-glib/default.nix

+    libtool
+    pkgconfig
+    vala
+    python


You should use either python3 and python3.pkgs, or python3Packages.python and python3Packages. In the worst case, those two variants can point to a different packages.

Also no need to use with construct for just a single package.

yeah no with.

I'm using python3Packages.python and the same for python3Packages.pygobject3 already.

jtojnar · 2018-07-07T14:03:35Z

pkgs/development/libraries/libgsignon-glib/default.nix

+
+  LC_ALL = "en_US.UTF-8";
+
+  # Don't treat trivial warnings as errors resulting in build failure


Could you also add a link to upstream issue?

jtojnar · 2018-07-07T14:03:54Z

pkgs/development/libraries/libgsignon-glib/default.nix

+  preConfigure = "NOCONFIGURE=1 ./autogen.sh";
+
+  configureFlags = [
+    "--enable-introspection=yes"


No need for yes.

worldofpeace · 2018-07-07T14:17:13Z

pkgs/development/libraries/libgsignon-glib/default.nix

+    python
+  ];
+
+  buildInputs = with python3Packages; [


no with here either I suppose

xeji · 2018-08-01T14:14:01Z

@GrahamcOfBorg build gsignond libgsignon-glib

GrahamcOfBorg · 2018-08-01T14:14:45Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gsignond, libgsignon-glib

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

jtojnar · 2018-08-01T14:16:11Z

@xeji I believe this is still WIP, the components do not work together.

GrahamcOfBorg · 2018-08-01T14:17:09Z

Success on aarch64-linux (full log)

Attempted: gsignond, libgsignon-glib

Partial log (click to expand)

strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/gfj4rbcxlh1ymwf1gwq6gjnqvd7jz0js-libgsignon-glib-2.4.1-devdoc
checking for references to /build in /nix/store/gfj4rbcxlh1ymwf1gwq6gjnqvd7jz0js-libgsignon-glib-2.4.1-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/k1g7i38flmjh9kpwkl2xjmambvr2bw1l-libgsignon-glib-2.4.1-py
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k1g7i38flmjh9kpwkl2xjmambvr2bw1l-libgsignon-glib-2.4.1-py/lib
patching script interpreter paths in /nix/store/k1g7i38flmjh9kpwkl2xjmambvr2bw1l-libgsignon-glib-2.4.1-py
checking for references to /build in /nix/store/k1g7i38flmjh9kpwkl2xjmambvr2bw1l-libgsignon-glib-2.4.1-py...
/nix/store/6n082wbhayzj06w38n7v99vwrzwi53xn-gsignond-1.0.7
/nix/store/mmg2zj5c6qdpjlmw89zshp6a3qlz16qy-libgsignon-glib-2.4.1

GrahamcOfBorg · 2018-08-01T14:17:57Z

Success on x86_64-linux (full log)

Attempted: gsignond, libgsignon-glib

Partial log (click to expand)

strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/48npf5vnk3zjxkwjakzga1m4dvz85bj8-libgsignon-glib-2.4.1-devdoc
checking for references to /build in /nix/store/48npf5vnk3zjxkwjakzga1m4dvz85bj8-libgsignon-glib-2.4.1-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/6n9dq672fzkipkvnni8rgj49ihzjr5b2-libgsignon-glib-2.4.1-py
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6n9dq672fzkipkvnni8rgj49ihzjr5b2-libgsignon-glib-2.4.1-py/lib
patching script interpreter paths in /nix/store/6n9dq672fzkipkvnni8rgj49ihzjr5b2-libgsignon-glib-2.4.1-py
checking for references to /build in /nix/store/6n9dq672fzkipkvnni8rgj49ihzjr5b2-libgsignon-glib-2.4.1-py...
/nix/store/0b5520k3f2hpj6396db6m93wrxf4si57-gsignond-1.0.7
/nix/store/pnzzwsv10f433mp1ccmkn6ky2m0ykjsl-libgsignon-glib-2.4.1

xeji · 2018-08-01T14:19:09Z

ok, let's wait until @worldofpeace says it's ready.

worldofpeace · 2018-08-01T16:30:17Z

This was far off in the corner of my head. Also this concerns me. So this might get stale until I package the plugins and Make it work ™

jtojnar · 2018-10-15T21:33:37Z

gsignond can be wrapped with these plugins.

I'm using it like this

I am talking about libgsignon-glib, that one seems to be abandoned in favour of libsingon-glib, see the pull requests linked in the elementary issue.

worldofpeace · 2018-10-15T21:38:17Z

Lol, these names are just confusing. It's used for nothing so I'll remove it.

worldofpeace · 2018-10-16T13:23:00Z

@jtojnar
Went ahead and removed signond because it didn't make sense to add it here.

Btw they don't need the sasl plugin but I'm adding it because they're expanding this feature.
So they might need it in the future just not right now. (I think)

pkgs/development/libraries/libsignon-glib/default.nix

nixos/modules/services/desktops/gsignond.nix

pkgs/development/libraries/gsignond/default.nix

worldofpeace · 2018-10-24T14:06:18Z

@GrahamcOfBorg build gsignond gsignondPlugins.sasl gsignondPlugins.oauth gsignondPlugins.lastfm gsignondPlugins.mail libsignon-glib

GrahamcOfBorg · 2018-10-24T14:07:16Z

Success on aarch64-linux (full log)

Attempted: gsignond, gsignondPlugins.sasl, gsignondPlugins.oauth, gsignondPlugins.lastfm, gsignondPlugins.mail, libsignon-glib

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yykwkg85504ph12l7y5qvvy2z5c1xqsj-gsignond-plugin-oauth-2018-10-15/lib
patching script interpreter paths in /nix/store/yykwkg85504ph12l7y5qvvy2z5c1xqsj-gsignond-plugin-oauth-2018-10-15
checking for references to /build in /nix/store/yykwkg85504ph12l7y5qvvy2z5c1xqsj-gsignond-plugin-oauth-2018-10-15...
/nix/store/ss1afjzkqi8m32j61hk6kfsvwpi243ji-gsignond-2018-10-04
/nix/store/iwqnhgyy2pzx2fvm6xvsrrp5d67rdlaj-gsignond-plugin-sasl-2018-10-15
/nix/store/yykwkg85504ph12l7y5qvvy2z5c1xqsj-gsignond-plugin-oauth-2018-10-15
/nix/store/m7jv5d4slx6gcpg2zzqavhiipbij51qa-gsignond-plugin-lastfm-2018-05-07
/nix/store/x4vnra1blj52f0jipg1iycn8glfkhfzl-gsignond-plugin-mail-2018-10-04
/nix/store/sdashpzi5cv1vyk89lq0n4skq1rb4pns-libsignon-glib-2018-10-24

GrahamcOfBorg · 2018-10-24T14:08:00Z

Success on x86_64-linux (full log)

Attempted: gsignond, gsignondPlugins.sasl, gsignondPlugins.oauth, gsignondPlugins.lastfm, gsignondPlugins.mail, libsignon-glib

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qdjj493s7irx5wpd585nmzz9k9z4k94a-gsignond-plugin-sasl-2018-10-15/lib
patching script interpreter paths in /nix/store/qdjj493s7irx5wpd585nmzz9k9z4k94a-gsignond-plugin-sasl-2018-10-15
checking for references to /build in /nix/store/qdjj493s7irx5wpd585nmzz9k9z4k94a-gsignond-plugin-sasl-2018-10-15...
/nix/store/jncbq5kpaj8qz7k5aill8byll7yk9936-gsignond-2018-10-04
/nix/store/qdjj493s7irx5wpd585nmzz9k9z4k94a-gsignond-plugin-sasl-2018-10-15
/nix/store/y6ja4xd31z5gljjsbqwq1g39w3jdxcv6-gsignond-plugin-oauth-2018-10-15
/nix/store/a7jsignmf240pfcpiwqr598glk7mdbn8-gsignond-plugin-lastfm-2018-05-07
/nix/store/if2kzwvky6i1kxf8lgf85p0db5wlsyaz-gsignond-plugin-mail-2018-10-04
/nix/store/r9935znx25zxv7pg8y60p2a8hq7pg1hd-libsignon-glib-2018-10-24

worldofpeace · 2018-10-24T18:21:28Z

@jtojnar

I think this is ready enough I guess 😄

All patches that I could upstream have been merged.

pkgs/development/libraries/libsignon-glib/default.nix

worldofpeace · 2018-10-26T17:00:47Z

Can this be merged as a precursor to #48637?
It would lighten testing.

jtojnar · 2018-10-26T17:30:09Z

Thanks for all the work.

worldofpeace · 2018-10-26T17:31:38Z

No problem.

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jul 7, 2018

worldofpeace force-pushed the gsignond branch from 222a09a to ad673df Compare July 7, 2018 10:52

jtojnar reviewed Jul 7, 2018

View reviewed changes

worldofpeace commented Jul 7, 2018

View reviewed changes

worldofpeace force-pushed the gsignond branch 3 times, most recently from 630ab93 to 5787c7f Compare July 7, 2018 12:10

worldofpeace changed the title ~~gsignond: init at 1.0.7~~ WIP: gsignond: init at 1.0.7 Jul 7, 2018

jtojnar reviewed Jul 7, 2018

View reviewed changes

worldofpeace force-pushed the gsignond branch 2 times, most recently from c12b504 to 529ddfd Compare July 7, 2018 12:58

jtojnar reviewed Jul 7, 2018

View reviewed changes

pkgs/development/libraries/libgsignon-glib/default.nix Outdated Show resolved Hide resolved

worldofpeace force-pushed the gsignond branch 4 times, most recently from 249c058 to 2d2cc15 Compare July 7, 2018 13:56

worldofpeace changed the title ~~WIP: gsignond: init at 1.0.7~~ gsignond: init at 1.0.7 Jul 7, 2018

jtojnar reviewed Jul 7, 2018

View reviewed changes

worldofpeace commented Jul 7, 2018

View reviewed changes

worldofpeace force-pushed the gsignond branch from 2d2cc15 to ccdbefc Compare July 7, 2018 14:28

worldofpeace force-pushed the gsignond branch 2 times, most recently from 7e69322 to e7e1ead Compare October 16, 2018 13:18

worldofpeace force-pushed the gsignond branch from e7e1ead to d908d1b Compare October 16, 2018 15:23

worldofpeace mentioned this pull request Oct 17, 2018

pantheon: init at 5.0 #48637

Merged

6 tasks

jtojnar reviewed Oct 17, 2018

View reviewed changes

pkgs/development/libraries/libsignon-glib/default.nix Outdated Show resolved Hide resolved

worldofpeace force-pushed the gsignond branch from d908d1b to 0c35b13 Compare October 17, 2018 19:48

jtojnar reviewed Oct 17, 2018

View reviewed changes

nixos/modules/services/desktops/gsignond.nix Outdated Show resolved Hide resolved

pkgs/development/libraries/gsignond/default.nix Outdated Show resolved Hide resolved

worldofpeace added 6 commits October 19, 2018 06:29

gsignond: init at 2018-10-04

1917c7d

gsignondPlugins.sasl: init at 2017-11-11

3522d66

gsignondPlugins.oauth: init at 2018-10-04

0bcd20e

gsignondPlugins.lastfm: init at 2018-05-07

9521044

gsignondPlugins.mail: init at 2018-10-04

518e7eb

nixos/gsignond: init

4f4e20b

worldofpeace force-pushed the gsignond branch 2 times, most recently from 9cd55b2 to 1380a5c Compare October 24, 2018 12:56

jtojnar reviewed Oct 24, 2018

View reviewed changes

pkgs/development/libraries/libsignon-glib/default.nix Outdated Show resolved Hide resolved

libsignon-glib: init at 2.0

923e2af

worldofpeace force-pushed the gsignond branch from 1380a5c to 923e2af Compare October 24, 2018 18:46

jtojnar merged commit 8221883 into NixOS:master Oct 26, 2018

worldofpeace deleted the gsignond branch October 26, 2018 17:31

		@@ -0,0 +1,37 @@
		{ stdenv, fetchFromGitLab, pkgconfig, meson, ninja, glib, glib-networking, sqlite, gobjectIntrospection, vala }:


		LC_ALL = "en_US.UTF-8";

		# Don't treat trivial warnings as errors resulting in build failure

gsignond: init at 1.0.7 #43133

gsignond: init at 1.0.7 #43133

Conversation

worldofpeace commented Jul 7, 2018

Motivation for this change

Things done

worldofpeace commented Jul 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xeji commented Aug 1, 2018

GrahamcOfBorg commented Aug 1, 2018

jtojnar commented Aug 1, 2018

GrahamcOfBorg commented Aug 1, 2018

GrahamcOfBorg commented Aug 1, 2018

xeji commented Aug 1, 2018

worldofpeace commented Aug 1, 2018

jtojnar commented Oct 15, 2018 • edited

worldofpeace commented Oct 15, 2018

worldofpeace commented Oct 16, 2018

worldofpeace commented Oct 24, 2018

GrahamcOfBorg commented Oct 24, 2018

GrahamcOfBorg commented Oct 24, 2018

worldofpeace commented Oct 24, 2018

worldofpeace commented Oct 26, 2018

jtojnar commented Oct 26, 2018

worldofpeace commented Oct 26, 2018

jtojnar commented Oct 15, 2018 •

edited