Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qsyncthingtray: fix compile with Qt 5.11 #43158

Closed
wants to merge 1 commit into from
Closed

qsyncthingtray: fix compile with Qt 5.11 #43158

wants to merge 1 commit into from

Conversation

urkud
Copy link
Contributor

@urkud urkud commented Jul 8, 2018

Motivation for this change

qsyncthingtray fails to compile with Qt 5.11 because of the lack of qt5_use_modules.
Grab a patch from upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg build qsyncthingtray

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qsyncthingtray

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5wbvwjd66xf8v1ds4dichjsh9lxl7vxj-qsyncthingtray-0.5.8
shrinking /nix/store/5wbvwjd66xf8v1ds4dichjsh9lxl7vxj-qsyncthingtray-0.5.8/bin/qsyncthingtray
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5wbvwjd66xf8v1ds4dichjsh9lxl7vxj-qsyncthingtray-0.5.8/bin
patching script interpreter paths in /nix/store/5wbvwjd66xf8v1ds4dichjsh9lxl7vxj-qsyncthingtray-0.5.8
checking for references to /build in /nix/store/5wbvwjd66xf8v1ds4dichjsh9lxl7vxj-qsyncthingtray-0.5.8...
postPatchMkspecs
postPatchMkspecs
/nix/store/5wbvwjd66xf8v1ds4dichjsh9lxl7vxj-qsyncthingtray-0.5.8

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: qsyncthingtray

Partial log (click to expand)

[6918/16620] CXX obj/third_party/webrtc/pc/peerconnection/mediastream.o
[6919/16620] CXX obj/third_party/webrtc/modules/audio_coding/neteq/packet_buffer.o
[6920/16620] CXX obj/third_party/webrtc/p2p/rtc_p2p/stunport.o
[6921/16620] CXX obj/third_party/webrtc/p2p/rtc_p2p/transportdescriptionfactory.o
[6922/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp_format/report_block.o
[6923/16620] CXX obj/third_party/webrtc/p2p/rtc_p2p/udptransport.o
[6924/16620] CXX obj/third_party/webrtc/pc/peerconnection/videotrack.o
building of '/nix/store/n7rqbpjnb85rl07h8r2ra2qz3906kxj5-qtwebengine-5.11.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/zg17kdqdnlf2xy5gkbqvr2gs1cdr0s7z-qsyncthingtray-0.5.8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/zg17kdqdnlf2xy5gkbqvr2gs1cdr0s7z-qsyncthingtray-0.5.8.drv' failed

@dotlambda
Copy link
Member

dotlambda commented Jul 8, 2018 •
edited

I think qt5_use_modules was restored in 5.11.1. Qsyncthingtray builds just fine for me.

@orivej
Copy link
Contributor

orivej commented Jul 8, 2018

Yes, Qt has decided to keep qt5_use_modules in Qt 5. Qt 5.11.1 was merged in #42351.

@urkud
Copy link
Contributor Author

urkud commented Jul 8, 2018

I've created this branch before 5.11.1 was in nixpkgs, then forgot to test that there is a problem to solve before submitting a pull request. Sorry.

@orivej
Copy link
Contributor

orivej commented Jul 8, 2018

No problem. Thanks for improving Nixpkgs!

@urkud urkud deleted the qsyncthingtray-qt-5-11 branch September 19, 2018 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@urkud @infinisil @GrahamcOfBorg @dotlambda @orivej @orivej-nixos