Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

super-productivity: init at 1.10.45 #43142

Merged
merged 1 commit into from Jul 9, 2018
Merged

super-productivity: init at 1.10.45 #43142

merged 1 commit into from Jul 9, 2018

Conversation

offlinehacker
Copy link
Contributor

No description provided.

@offlinehacker offlinehacker force-pushed the pkgs/super-productivity/init branch 3 times, most recently from e631e9b to a318e87 Compare July 7, 2018 14:53
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: super-productivity

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: super-productivity

Partial log (click to expand)


trying https://github.com/johannesjo/super-productivity/releases/download/1.10.45/superProductivity_1.10.45_amd64.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download superProductivity_1.10.45_amd64.deb from any mirror
builder for '/nix/store/4lm8lrzlg9dvkk51p7q5lqq14xkac9pz-superProductivity_1.10.45_amd64.deb.drv' failed with exit code 1
cannot build derivation '/nix/store/skyvm4mk60cmgwffx7svi084py122jni-super-productivity-1.10.45.drv': 1 dependencies couldn't be built
error: build of '/nix/store/skyvm4mk60cmgwffx7svi084py122jni-super-productivity-1.10.45.drv' failed

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: super-productivity

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: super-productivity

Partial log (click to expand)

copying path '/nix/store/whk2gs9h5ksykqbq33vw9rd24c7bgiqy-xprintidle-ng-git-2015-09-01' from 'https://cache.nixos.org'...
building '/nix/store/7dzav7hv96c9g1jxmq77wa1jkcpxvkzh-superProductivity_1.10.45_amd64.deb.drv'...

trying https://github.com/johannesjo/super-productivity/releases/download/v1.10.45/superProductivity_1.10.45_amd64.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   625    0   625    0     0   1636      0 --:--:-- --:--:-- --:--:--  1636
100 38.0M  100 38.0M    0     0  10.5M      0  0:00:03  0:00:03 --:--:-- 12.8M
building '/nix/store/agmi4knksw4wmypd27q6csxwrz0hda3m-super-productivity-1.10.45.drv'...
/nix/store/5dvqqmn61qpkyr6bywdcf8wsfgy7jnzi-super-productivity-1.10.45

adisbladis
adisbladis reviewed Jul 8, 2018
View reviewed changes
pkgs/applications/networking/super-productivity/default.nix Outdated
nativeBuildInputs = [ makeWrapper ];

unpackPhase = "true";
buildCommand = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit awkward to have all phases in one like this, makes overriding difficult.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied slack derivation, i can put it in install phase nad disable other phases, do you think that would be better?

adisbladis
adisbladis reviewed Jul 8, 2018
View reviewed changes
pkgs/applications/networking/super-productivity/default.nix Outdated
--replace /opt/superProductivity/ $out/bin/
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No maintainer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, again, slack package did not have maintainer, so i forgot.

@offlinehacker
Copy link
Contributor Author

Ok, i split into unpackPhase and installPhase, i also called preInstall and postInstall hooks from installPhase. For fixupPhase i had to disable striping. Also added me as maintainer.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: super-productivity

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lwhr13k02sksh0n3mdf4vyllppns9i9r-super-productivity-1.10.45
shrinking /nix/store/lwhr13k02sksh0n3mdf4vyllppns9i9r-super-productivity-1.10.45/libexec/superProductivity/libnode.so
shrinking /nix/store/lwhr13k02sksh0n3mdf4vyllppns9i9r-super-productivity-1.10.45/libexec/superProductivity/superproductivity
shrinking /nix/store/lwhr13k02sksh0n3mdf4vyllppns9i9r-super-productivity-1.10.45/libexec/superProductivity/libffmpeg.so
patching script interpreter paths in /nix/store/lwhr13k02sksh0n3mdf4vyllppns9i9r-super-productivity-1.10.45
head: error writing 'standard output': Broken pipe
checking for references to /build in /nix/store/lwhr13k02sksh0n3mdf4vyllppns9i9r-super-productivity-1.10.45...
/nix/store/lwhr13k02sksh0n3mdf4vyllppns9i9r-super-productivity-1.10.45

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: super-productivity

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@adisbladis
Copy link
Member

Much better. Thanks :)

@adisbladis adisbladis merged commit cac85f6 into NixOS:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@offlinehacker @GrahamcOfBorg @adisbladis