Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del mesa-darwin: fossil (2012 version) #43145

Closed

Conversation

Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented Jul 7, 2018

Motivation for this change
Main point

(2018-06-29) v18.1.3 - mesa
(2012-10-24) v08.0.3 - mesa-darwin

I do mesa v18 work, and mesa-darwin v8 relies on mesa and creates conflicts during evaluation.

Good point is - from 2012 to this date it was evaluating - that shows the stability achieved by the Nix approach.

###### Serious jokes

I really can not test mesa-darwin v8, both because of architecture, and because it is mesa in 2012 edition style.

I summon the @jtojnar - daedric prince! One of your spheres of influence is guiding forces to cleanse the old, so new comes to the world.

###### Fun time
I, not once, checked everything. Now is the only time I probably ever give myself that fun:

- [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
- Built on platform(s)
_ - [x] NixOS_
_ - [x] macOS_
_ - [x] other Linux distributions_
- [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
- [x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
- [x] Tested execution of all binary files (usually in ./result/bin/)
- [x] Determined the impact on package closure size (by running nix path-info -S before and after)
- [x] Fits CONTRIBUTING.md.

Yes! I did it! 8)

Seriously, it conflicts with mesa.


@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Jul 7, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Jul 7, 2018

You seem to have just removed the expression without removing the package calls.

$ rg libGLDarwin
pkgs/top-level/all-packages.nix
10888:  libGL = libGLDarwinOr mesa_noglu.stubs;
10891:  libGLU = libGLDarwinOr mesa_glu;
10897:  libGLU_combined = libGLDarwinOr (buildEnv {
10904:  libGL_driver = libGLDarwinOr mesa_drivers;
10908:  libGLDarwin = callPackage ../development/libraries/mesa-darwin {
10914:  libGLDarwinOr = alternative: if stdenv.isDarwin then libGLDarwin else alternative;

Also I would like to hear from @cstrahan or someone if this relict is still needed.

@Anton-Latukha Anton-Latukha changed the base branch from master to staging July 7, 2018 17:22
@matthewbauer
Copy link
Member

Yes we need to get latest mesa to build on macOS before we can start doing this.

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Jul 8, 2018

@matthewbauer

Please say more.
I don't understood the message: "we need to get latest mesa build on macOS before we can start" deleting it?

@matthewbauer
Copy link
Member

I don't understood the message: "we need to get latest mesa build on macOS before we can start" deleting it?

Yes - the problem right now is that mesa-darwin is still used in a few places (mostly xorg stuff). It definitely should be removed because it is unmaintained & out of date but we don't have a good alternative yet.

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Jul 9, 2018

Ok. Than in fact I can avoid this versions situation.

  1. Also new mesa can be built with meson. If you can write a hint how to correctly make right overload of nativeBuildInputs for mesa-darwin, so I would be sure and go the right path on next resubmit.

  2. I would submit pull request version with both mesa and moving legacy stuff to mesa-darwin, so that chain would work with current Nix mesa-darwin.

  3. Then would open issue for mesa-darwin, because there is none at the moment.

@Anton-Latukha
Copy link
Contributor Author

Closed in favor of both: 1) #43378, 2) seems still used to some degree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants