Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: guix: init at 0.15.0 #43221

Closed
wants to merge 3 commits into from
Closed

WIP: guix: init at 0.15.0 #43221

wants to merge 3 commits into from

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jul 8, 2018

Motivation for this change

For fun?

guix doesn't compile yet as it's not able to find guile-git for some reason. I don't have enough guile knowledge or willpower left to debug this further.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm requested a review from vrthra July 8, 2018 14:36
@zimbatm
Copy link
Member Author

zimbatm commented Jul 8, 2018

Please close this PR in a week if nobody showed interest in this PR.
93ff16b is the only commit that is master-worthy.

@ryantm
Copy link
Member

ryantm commented Jul 8, 2018

@zimbatm To me, it seems quite clear that we want guix to be available; I hope you can get it to work!

@zimbatm
Copy link
Member Author

zimbatm commented Jul 8, 2018

I wonder how it's all going to integrate if the package is installed by nix, I guess guix will want to also install guix with itself as well.

@domenkozar
Copy link
Member

btw we had guix but I removed it since noone wanted to maintain it (version was very very old).

adisbladis
adisbladis reviewed Jul 9, 2018
View reviewed changes
pkgs/development/interpreters/guile/setup-hook-2.2.sh Outdated
addToSearchPath GUILE_LOAD_PATH "$1/share/guile/site"
fi

if [[ -d "$1/lib/guile/2.0/site-ccache" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: 2.0 -> $ver

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

pkgs/tools/package-management/guix/default.nix
pkgconfig
];

buildInputs = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix is also a required buildInput

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added

@zimbatm
Copy link
Member Author

zimbatm commented Jul 9, 2018

@GrahamcOfBorg build guix

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: guix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@zimbatm
Copy link
Member Author

zimbatm commented Jul 9, 2018

btw we had guix but I removed it since noone wanted to maintain it (version was very very old).

Yeah I don't know if this is worth it to be honest. I'll close the PR and submit another one for the guile hooks improvements.

@zimbatm
guile: hook the cache properly
997c0ad 
The pre-compiled .go files are put in the lib/guile folder when they
exist.
@zimbatm
WIP: lots of new guile modules for guix
9450fdb
@zimbatm
guix: init at 0.15.0
b17e818
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: guix

Partial log (click to expand)

checking for guile2... no
checking for guile... /nix/store/mlk0is342s1v3cbsmpbixpj21dn64gda-guile-2.2.3/bin/guile
checking for Guile version >= 2.2... 2.2.3
checking for guild... /nix/store/mlk0is342s1v3cbsmpbixpj21dn64gda-guile-2.2.3/bin/guild
checking for guile-config... /nix/store/mlk0is342s1v3cbsmpbixpj21dn64gda-guile-2.2.3/bin/guile-config
checking if (gnutls) is available... yes
checking if (git) is available... no
configure: error: Guile-Git is missing; please install it.
builder for '/nix/store/fj07cqn6kx3nq2176isdfkmn709ngsnf-guix-0.15.0.drv' failed with exit code 1
error: build of '/nix/store/fj07cqn6kx3nq2176isdfkmn709ngsnf-guix-0.15.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: guix

Partial log (click to expand)

checking for guile2... no
checking for guile... /nix/store/pjprm0hnxgd0zpmik8ixcpikb5klfrqp-guile-2.2.3/bin/guile
checking for Guile version >= 2.2... 2.2.3
checking for guild... /nix/store/pjprm0hnxgd0zpmik8ixcpikb5klfrqp-guile-2.2.3/bin/guild
checking for guile-config... /nix/store/pjprm0hnxgd0zpmik8ixcpikb5klfrqp-guile-2.2.3/bin/guile-config
checking if (gnutls) is available... yes
checking if (git) is available... no
configure: error: Guile-Git is missing; please install it.
builder for ‘/nix/store/w50vhq00rmn877dp6ajz8kv78w14kn92-guix-0.15.0.drv’ failed with exit code 1
error: build of ‘/nix/store/w50vhq00rmn877dp6ajz8kv78w14kn92-guix-0.15.0.drv’ failed

@timokau
Copy link
Member

timokau commented Jul 9, 2018

This would also make it easier to tinker with and take inspiration from (read steal) guix's good usability ideas.

@ryantm
Copy link
Member

ryantm commented Sep 8, 2018

I think it would be nice to get guix into nixpkgs, but @zimbatm said he would close this, so I'm closing it for now.

@ryantm ryantm closed this Sep 8, 2018
@zimbatm zimbatm deleted the guix-0.15.0 branch December 13, 2018 12:33
@pukkamustard pukkamustard mentioned this pull request Feb 26, 2019
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zimbatm @ryantm @domenkozar @GrahamcOfBorg @timokau @adisbladis