Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: install shell completions #43143

Merged
merged 1 commit into from Jul 8, 2018
Merged

alacritty: install shell completions #43143

merged 1 commit into from Jul 8, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

https://github.com/jwilm/alacritty#shell-completions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Mic92

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: alacritty

Partial log (click to expand)


test result: ok. 1 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ranf3z8xpn7yv5vnaf72k35z8bjp7k1l-alacritty-unstable-2018-05-09/bin
patching script interpreter paths in /nix/store/ranf3z8xpn7yv5vnaf72k35z8bjp7k1l-alacritty-unstable-2018-05-09
checking for references to /build in /nix/store/ranf3z8xpn7yv5vnaf72k35z8bjp7k1l-alacritty-unstable-2018-05-09...
/nix/store/ranf3z8xpn7yv5vnaf72k35z8bjp7k1l-alacritty-unstable-2018-05-09

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: alacritty

Partial log (click to expand)


test result: ok. 1 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bi9bybhik5jrs9xnh8mnr5x2pvzdanv7-alacritty-unstable-2018-05-09/bin
patching script interpreter paths in /nix/store/bi9bybhik5jrs9xnh8mnr5x2pvzdanv7-alacritty-unstable-2018-05-09
checking for references to /build in /nix/store/bi9bybhik5jrs9xnh8mnr5x2pvzdanv7-alacritty-unstable-2018-05-09...
/nix/store/bi9bybhik5jrs9xnh8mnr5x2pvzdanv7-alacritty-unstable-2018-05-09

infinisil
infinisil reviewed Jul 7, 2018
View reviewed changes
pkgs/applications/misc/alacritty/default.nix Outdated
@@ -92,6 +92,10 @@ in buildRustPackage rec {
patchelf --set-rpath "${stdenv.lib.makeLibraryPath rpathLibs}" $out/bin/alacritty
'') + ''

install -D alacritty-completions.zsh "$out/share/zsh/site-functions/_alacritty"
install -Dt "$out/etc/bash_completion.d" alacritty-completions.bash
install -D alacritty-completions.fish "$out/share/fish/vendor_completions.d/alacritty.fish"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really bothers me how the second line has the target as the first parameter while the others do not!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could change that, but then it would bother me that alacritty-completions.bash turns up twice in that line :D

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: alacritty

Partial log (click to expand)


test result: ok. 1 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aq5g2r4l4fh6mn888camam4p4wd2cjvx-alacritty-unstable-2018-05-09/bin
patching script interpreter paths in /nix/store/aq5g2r4l4fh6mn888camam4p4wd2cjvx-alacritty-unstable-2018-05-09
checking for references to /build in /nix/store/aq5g2r4l4fh6mn888camam4p4wd2cjvx-alacritty-unstable-2018-05-09...
/nix/store/aq5g2r4l4fh6mn888camam4p4wd2cjvx-alacritty-unstable-2018-05-09

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: alacritty

Partial log (click to expand)


test result: ok. 1 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9cz0cbfmq7slj67j9y3c6apn9wdk27zq-alacritty-unstable-2018-05-09/bin
patching script interpreter paths in /nix/store/9cz0cbfmq7slj67j9y3c6apn9wdk27zq-alacritty-unstable-2018-05-09
checking for references to /build in /nix/store/9cz0cbfmq7slj67j9y3c6apn9wdk27zq-alacritty-unstable-2018-05-09...
/nix/store/9cz0cbfmq7slj67j9y3c6apn9wdk27zq-alacritty-unstable-2018-05-09

@infinisil infinisil merged commit 784f543 into NixOS:master Jul 8, 2018
@infinisil
Copy link
Member

Awesome :)

@dotlambda dotlambda deleted the alacritty-completions branch March 21, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @GrahamcOfBorg @infinisil