Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfcrack: init 0.16 #43144

Merged
merged 1 commit into from Jul 7, 2018
Merged

pdfcrack: init 0.16 #43144

merged 1 commit into from Jul 7, 2018

Conversation

qoelet
Copy link
Member

@qoelet qoelet commented Jul 7, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda reviewed Jul 7, 2018
View reviewed changes
pkgs/tools/security/pdfcrack/default.nix Outdated

installPhase = ''
mkdir -p $out/bin
mv pdfcrack $out/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install -Dt $out/bin pdfcrack

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's definitely nicer, amended.

pkgs/tools/security/pdfcrack/default.nix Outdated
homepage = http://pdfcrack.sourceforge.net/;
description = "Small command line driven tool for recovering passwords and content from PDF files";
license = with licenses; [ gpl2 ];
platforms = stdenv.lib.platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no stdenv.lib

@dotlambda
Copy link
Member

@GrahamcOfBorg build pdfcrack

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pdfcrack

Partial log (click to expand)

gcc -Wall -Wextra -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -O3 -g   -o pdfcrack main.o sha256.o rc4.o md5.o pdfcrack.o pdfparser.o passwords.o common.o benchmark.o
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r22ryf036f8i4wx9ik8d4l2bw3r7rwd9-pdfcrack-0.16
shrinking /nix/store/r22ryf036f8i4wx9ik8d4l2bw3r7rwd9-pdfcrack-0.16/bin/pdfcrack
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r22ryf036f8i4wx9ik8d4l2bw3r7rwd9-pdfcrack-0.16/bin
patching script interpreter paths in /nix/store/r22ryf036f8i4wx9ik8d4l2bw3r7rwd9-pdfcrack-0.16
checking for references to /build in /nix/store/r22ryf036f8i4wx9ik8d4l2bw3r7rwd9-pdfcrack-0.16...
/nix/store/r22ryf036f8i4wx9ik8d4l2bw3r7rwd9-pdfcrack-0.16

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pdfcrack

Partial log (click to expand)

gcc -Wall -Wextra -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -O3 -g   -o pdfcrack main.o sha256.o rc4.o md5.o pdfcrack.o pdfparser.o passwords.o common.o benchmark.o
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ckb3vcsfd737jbxsv1zp2c1s7sf6ng19-pdfcrack-0.16
shrinking /nix/store/ckb3vcsfd737jbxsv1zp2c1s7sf6ng19-pdfcrack-0.16/bin/pdfcrack
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ckb3vcsfd737jbxsv1zp2c1s7sf6ng19-pdfcrack-0.16/bin
patching script interpreter paths in /nix/store/ckb3vcsfd737jbxsv1zp2c1s7sf6ng19-pdfcrack-0.16
checking for references to /build in /nix/store/ckb3vcsfd737jbxsv1zp2c1s7sf6ng19-pdfcrack-0.16...
/nix/store/ckb3vcsfd737jbxsv1zp2c1s7sf6ng19-pdfcrack-0.16

@dotlambda dotlambda merged commit 638fb3e into NixOS:master Jul 7, 2018
@qoelet qoelet deleted the pdfcrack branch July 7, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qoelet @dotlambda @GrahamcOfBorg