Fix broken build.x86_64-linux job #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job has been failing since https://hydra.nixos.org/eval/1461286 with the following error: hydra-eval-jobs.cc:278:17: error: 'evalSettings' was not declared in this scope evalSettings.restrictEval = true; ^~~~~~~~~~~~ This is likely due to a typo in 0882519 where that line and the corresponding comment were moved, and `settings` was changed in that one place to `evalSettings`. I reproduced the error by running `nix-build release.nix -A build.x86_64-linux` on my machine, and this small change fixes it.
jmitchell
force-pushed
the
fix/evalSettings
branch
from
a9b077d
to
08de434
Compare
edolstra
added a commit
that referenced
this pull request
Jul 31, 2018
This reverts commit c2e2b42, which breaks building with nixUnstable.
tomberek
pushed a commit
to tomberek/hydra
that referenced
this pull request
Aug 21, 2018
The job has been failing since https://hydra.nixos.org/eval/1461286 with the following error: hydra-eval-jobs.cc:278:17: error: 'evalSettings' was not declared in this scope evalSettings.restrictEval = true; ^~~~~~~~~~~~ This is likely due to a typo in 0882519 where that line and the corresponding comment were moved, and `settings` was changed in that one place to `evalSettings`. I reproduced the error by running `nix-build release.nix -A build.x86_64-linux` on my machine, and this small change fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job has been failing since https://hydra.nixos.org/eval/1461286
with the following error:
This is likely due to a typo in 0882519 where that line and the
corresponding comment were moved, and
settingswas changed in thatone place to
evalSettings.I reproduced the error by running
nix-build release.nix -A build.x86_64-linuxon my machine, and this small change makes it build.