Indeed, all that 404s is not lost 😄

https://web.archive.org/web/20160527042358/http://benchmarksgame.alioth.debian.org/u64q/program.php?test=binarytrees&lang=yarv&id=1

@z64 Ah yeah using the waybackmachine for the links is a good idea.

@straight-shoota But I don't really see why it's a problem to replace the while trues with loop dos. It just reads better and is the prefered way to make a loop. And maybe a beginner takes some of these samples as a reference and then uses while true instead of loop do in his code..

Thank you for the PR, but the code as it is right now is fine.
While true is better than loop in my opinion.
Using tuple instead of Array is not always better (tuple should just be used to return multiple values, or to group values, but it makes little sense to use in constants)
I could go on but I don't have much time right now.
Please don't merge this.

Official samples should reflect idiomatic Crystal code and its best pratices. Although disagree with some changes (I'm included), this is a legitimate attempt to improve and bring consistency to samples code. I think we should agree on some basic changes (e.g. unifying while (true) and while true, using tuples for immutable data, etc), instead of keeping as is.

Using tuples for immutable data is not always correct. In samples all arrays have the same type. An array should be used, not a tuple. A tuple is not an immutable array.

Unifying code syntax is not important. The language allows for many styles, all are correct.

@r00ster91

But I don't really see why it's a problem to replace the while trues with loop dos.

And I don't see a problem with while true why that should be changed.

It just reads better and is the prefered way to make a loop.

Says who?

And maybe a beginner takes some of these samples as a reference and then uses while true instead of loop do in his code..

And that's perfectly fine. I'd even advice to do so.

Updating links to new locations is great. Code changes like content_type, too. Everything else doesn't make sense. Especially removing links and comments.

👍 for constants and abort.

Hmmmm okay changed it back to while true.

Also accessing constants is slower than accessing local variables. Please, there's no point to these PRs.

@asterite So I should revert the constants back to local variables? But at for example the SYMBOLS constant it says in the docs that theres currently a big performance problem because on every Int#times iteration a new array is created. And this is prevented by making SYMBOLS a constant. And that's also the case with SCENE I think.

But you are right with the SUDOKU string constant (I benchmarked). I'll change it.

That's if you use an array literal inside a loop. Accessing a local variable inside a loop is fine.

Alright changed it.

I resolved the conflicts. Is anything left?