Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

altcoins.mist: 0.10.0 -> 0.11.1 #44141

Merged
merged 1 commit into from Jul 28, 2018
Merged

altcoins.mist: 0.10.0 -> 0.11.1 #44141

merged 1 commit into from Jul 28, 2018

Conversation

jbboehr
Copy link
Contributor

@jbboehr jbboehr commented Jul 26, 2018

Motivation for this change

Update the Mist browser to the latest version and fix an issue similar to #43297

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jul 27, 2018 •
edited

The executable contains the current version number. Should there be a symlink from mist-${version} to mist?

@jbboehr
altcoins.mist: 0.10.0 -> 0.11.1
c835845 
* Add gtk2 as dependency, see NixOS#43297
* Don't include version number in mist executable name
@Mic92 Mic92 merged commit c70dee9 into NixOS:master Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbboehr @Mic92 @GrahamcOfBorg