grv: 0.1.2 -> 0.2.0 #44137
Merged
grv: 0.1.2 -> 0.2.0 #44137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs libgit2 0.27 apparently, doesn't build with 0.26 or 0.25 in-tree.
|
Success on aarch64-linux (full log) Attempted: libgit2_0_27 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libgit2_0_27 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libgit2_0_27 Partial log (click to expand)
|
|
Ah, it's libgit2-glib holding us back I think: https://gitlab.gnome.org/GNOME/libgit2-glib/issues/1 |
Mic92
reviewed
Jul 27, 2018
pkgs/top-level/all-packages.nix
Outdated
| @@ -9339,6 +9339,10 @@ with pkgs; | |||
| inherit (darwin.apple_sdk.frameworks) Security; | |||
| }; | |||
|
|
|||
| libgit2_0_27 = callPackage ../development/libraries/git2/0.27.nix { | |||
There was a problem hiding this comment.
Does blsd also support libgit2_0_27? Then libgit2_0_25 can be dropped.
There was a problem hiding this comment.
Or maybe libgit2_0_26 which is what our libgit2 defaults to.
There was a problem hiding this comment.
go2nix needs to be re-run to update blsd.
|
glib bindings can be bumped like this: https://gitlab.gnome.org/smcv/libgit2-glib/commit/f6d7a149b40a7b131852f4daf8b428bbc993b12e |
|
If glib is the only blocker and can be fixed with the patch, then we can have a single version of libgit2 in nixpkgs. |
|
Success on x86_64-linux (full log) Attempted: blsd, libgit2_0_27 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: blsd, libgit2_0_27 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: blsd, libgit2_0_27 Partial log (click to expand)
|
|
Sounds good to me, is there someone who can approve/check? :) |
|
It looks fine and grv works as expected. The bumped deps don't seem to cause an outbreak of breakage. @dtzWill one minor nitpick is that I've built the affected packages locally. They look ok. Lets see what ofBorg says before I merge this just to be sure (about aarch64 and darwin…) |
|
Success on aarch64-linux (full log) Attempted: gitAndTools.grv, blsd, expect, time The following builds were skipped because they don't evaluate on aarch64-linux: julia_05, (I, julia, to, out...) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gitAndTools.grv, blsd, expect, time The following builds were skipped because they don't evaluate on aarch64-linux: julia_05, (I, julia, to, out...) Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: julia_05, gitAndTools.grv, blsd, expect, julia, time The following builds were skipped because they don't evaluate on x86_64-linux: (I, to, out...) Partial log (click to expand)
|
|
julia fails it's libgit test with the new version: |
|
Success on x86_64-darwin (full log) Attempted: julia_05, gitAndTools.grv, blsd, expect, julia, time The following builds were skipped because they don't evaluate on x86_64-darwin: (I, to, out...) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: julia_05, gitAndTools.grv, blsd, expect, julia, time The following builds were skipped because they don't evaluate on x86_64-darwin: (I, to, out...) Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: julia_05, gitAndTools.grv, blsd, expect, julia, time The following builds were skipped because they don't evaluate on x86_64-linux: (I, to, out...) Partial log (click to expand)
|
|
Actually it does not look like this version of julia receives updates from upstream. Should we just drop julia_4 and julia_5 instead of putting effort into this? |
|
I drop old versions of julia in this pull request: #44191 |
|
I think this pull request can be merged now. |
|
Success on aarch64-linux (full log) Attempted: blsd, libgit2_0_27 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: blsd, libgit2_0_27 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: blsd, libgit2_0_27 Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs newer libgit2 than we have,
so added variant for 0.27.
Our libgit2 has comments saying not to
update without other packages along with,
but when I looked earlier those didn't
support newer libgit2 :(.
That may have changed.
Anyway, yay grv update!
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)