Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.phpc(s|bf): 3.3.0 -> 3.3.1 #44143

Merged
merged 2 commits into from Jul 29, 2018
Merged

phpPackages.phpc(s|bf): 3.3.0 -> 3.3.1 #44143

merged 2 commits into from Jul 29, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Jul 27, 2018

Motivation for this change

Changelog: https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.3.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @javaguirre @CMCDragonkai

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: phpPackages.phpcbf, phpPackages.phpcs

Partial log (click to expand)

100 1111k  100 1111k    0     0  3358k      0 --:--:-- --:--:-- --:--:-- 3358k
copying path '/nix/store/gdjasgil4na1fs4ygq4lc7q9lwjsi9x8-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/2qis35nlk99gp830171xp192vzc2z919-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/033cjd9dvwflpbsdzcv7vg3n4z2578n0-stdenv-linux' from 'https://cache.nixos.org'...
building '/nix/store/jxwpm7f2ibykqhpjpd71y142czll4ayq-phpcbf-3.3.1.drv'...
building '/nix/store/c1zkdc37jlx7pqncr74padlz2gnpiw57-phpcs-3.3.1.drv'...
installing
installing
/nix/store/kgx0q8hbcqa94iqzrsnpzy9gs20qyry0-phpcbf-3.3.1
/nix/store/ibqi24vh1wi1yz3xv1k3c0lp71xfvcqp-phpcs-3.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: phpPackages.phpcbf, phpPackages.phpcs

Partial log (click to expand)

100   600    0   600    0     0   5263      0 --:--:-- --:--:-- --:--:--  5263
100   599    0   599    0     0   5254      0 --:--:-- --:--:-- --:--:--  5300
100 1111k  100 1111k    0     0  3846k      0 --:--:-- --:--:-- --:--:-- 3846k
100 1111k  100 1111k    0     0  3269k      0 --:--:-- --:--:-- --:--:-- 3269k
building '/nix/store/swp92xyf05pb9957qs021lxkgiac6k5b-phpcbf-3.3.1.drv'...
building '/nix/store/x13z2zmqx9klv37z88s333gmzbzrbl4z-phpcs-3.3.1.drv'...
installing
installing
/nix/store/xs8g5z76hn73ghdd5k2vw3j3l5x7rrg5-phpcbf-3.3.1
/nix/store/ln1qml04a2xcqkx2gb5f8x7cmhybznz5-phpcs-3.3.1

@infinisil infinisil merged commit 9865feb into NixOS:master Jul 29, 2018
@etu etu deleted the php-codesniffer-update branch July 29, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @GrahamcOfBorg @infinisil