Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yices: fix symlink created to match version #43445

Merged
merged 3 commits into from Jul 13, 2018
Merged

yices: fix symlink created to match version #43445

merged 3 commits into from Jul 13, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 12, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
yices: fix symlink to match version of package
6ff8685 
To help avoid this happening again, derive the string to use
from the version directly instead of embedding it in installPhase.
@dtzWill
yices: simplify ln command
237c8f4
@xeji
Copy link
Contributor

xeji commented Jul 13, 2018

builtins.splitVersion seems to be missing on the ofborg builder

@dtzWill
Copy link
Member Author

dtzWill commented Jul 13, 2018

builtins.splitVersion seems to be missing on the ofborg builder

Whoops, honestly was surprised to see it myself (nix repl completion woohoo), pushed a fix. Thanks!

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yices

Partial log (click to expand)

shrinking /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0/bin/yices-smt
shrinking /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0/bin/yices-sat
shrinking /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0/bin/yices
shrinking /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0/bin/yices-smt2
shrinking /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0/lib/libyices.so.2.6.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0/lib  /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0/bin
patching script interpreter paths in /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0
checking for references to /build in /nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0...
/nix/store/7plgga3kfwk1big8hr49vv417f6q2m9l-yices-2.6.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: yices

Partial log (click to expand)

/nix/store/5q51r2d0xzs4hi8rb661drpf83mhm4b4-coreutils-8.29/bin/install -c -m 664 build/x86_64-apple-darwin16.3.0-release/dist/include/* /nix/store/3046l7cfpas5373xnis3018ph48z2is8-yices-2.6.0/include
/nix/store/5q51r2d0xzs4hi8rb661drpf83mhm4b4-coreutils-8.29/bin/install -c build/x86_64-apple-darwin16.3.0-release/dist/bin/* /nix/store/3046l7cfpas5373xnis3018ph48z2is8-yices-2.6.0/bin
/nix/store/5q51r2d0xzs4hi8rb661drpf83mhm4b4-coreutils-8.29/bin/install -c build/x86_64-apple-darwin16.3.0-release/dist/lib/* /nix/store/3046l7cfpas5373xnis3018ph48z2is8-yices-2.6.0/lib
(cd /nix/store/3046l7cfpas5373xnis3018ph48z2is8-yices-2.6.0/lib && ln -s -f libyices.2.dylib libyices.dylib)
make[1]: Leaving directory '/private/tmp/nix-build-yices-2.6.0.drv-0/yices2-Yices-2.6.0'
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/3046l7cfpas5373xnis3018ph48z2is8-yices-2.6.0/lib  /nix/store/3046l7cfpas5373xnis3018ph48z2is8-yices-2.6.0/bin
patching script interpreter paths in /nix/store/3046l7cfpas5373xnis3018ph48z2is8-yices-2.6.0
/nix/store/3046l7cfpas5373xnis3018ph48z2is8-yices-2.6.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: yices

Partial log (click to expand)

shrinking /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0/lib/libyices.so.2.6.0
shrinking /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0/bin/yices-smt2
shrinking /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0/bin/yices-smt
shrinking /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0/bin/yices-sat
shrinking /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0/bin/yices
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0/lib  /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0/bin
patching script interpreter paths in /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0
checking for references to /build in /nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0...
/nix/store/khicb5xz78hb3y9fp9qf60xkyhbjpqsy-yices-2.6.0

@dtzWill dtzWill merged commit efdf471 into NixOS:master Jul 13, 2018
@dtzWill dtzWill deleted the fix/yices-symlink branch July 13, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @xeji @GrahamcOfBorg @thoughtpolice