Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: fix runtime qt environment #43426

Merged
merged 1 commit into from Jul 14, 2018
Merged

zoom-us: fix runtime qt environment #43426

merged 1 commit into from Jul 14, 2018

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

Fixes #43350

Add a few missing runtime dependencies (discovered with strace and QT_DEBUG_PLUGINS=1).

Rather than manually setting runtime paths in environment variables, re-use libsForQt5.env to build a usable runtime Qt environment and symlink its qt.conf. This seems to fix the issue in #43350 by setting the correct QML import paths.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: zoom-us

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: zoom-us

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@danbst
Copy link
Contributor

danbst commented Jul 12, 2018

Yay! Works now for me. Though I get annoying extra output in console:

qrc:/qml/SignInWaiting.qml:20:9: QML BusyIndicator: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:26:9: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:203:21: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:220:21: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:230:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:259:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:122:21: QML ZoomText: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:45:21: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:59:21: QML HyperLink: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:20:9: QML BusyIndicator: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:26:9: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:20:9: QML BusyIndicator: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:26:9: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:122:21: QML ZoomText: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:45:21: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:59:21: QML HyperLink: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:45:21: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:59:21: QML HyperLink: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:45:21: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:59:21: QML HyperLink: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:45:21: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:59:21: QML HyperLink: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:45:21: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:59:21: QML HyperLink: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:122:21: QML ZoomText: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:203:21: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:220:21: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:203:21: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:220:21: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:203:21: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:220:21: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:230:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:259:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:230:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:259:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:230:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:259:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:230:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignIn.qml:259:17: QML BorderImageButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:20:9: QML BusyIndicator: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:26:9: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:20:9: QML BusyIndicator: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/SignInWaiting.qml:26:9: QML Text: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
CSBConfUI::OnConfStatusChanged  UI_CMD_SHARE_READYqrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.
qrc:/qml/MeetingBottomBar.qml:410:9: QML Rectangle: Detected anchors on an item that is managed by a layout. This is undefined behavior;use Layout.alignment instead.

danbst
danbst reviewed Jul 12, 2018
View reviewed changes
pkgs/applications/networking/instant-messengers/zoom-us/default.nix
@@ -1,16 +1,18 @@
{ stdenv, fetchurl, system, makeWrapper, makeDesktopItem, autoPatchelfHook
{ stdenv, fetchurl, system, makeWrapper, makeDesktopItem, autoPatchelfHook, env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this env comes from? Name is so generic that it is impossible to grep out what it is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR mentions libsForQt5.env, I guess that's what the param refers to.

@joachifm joachifm merged commit bc48770 into NixOS:master Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@danbst danbst danbst left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zoom GUI is not shown
4 participants
@tadfisher @GrahamcOfBorg @danbst @joachifm