Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2-cutter: don't wrap, shouldn't be needed (and might be wrong) #43425

Merged
merged 1 commit into from Jul 12, 2018
Merged

radare2-cutter: don't wrap, shouldn't be needed (and might be wrong) #43425

merged 1 commit into from Jul 12, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 12, 2018

This was working around mixed qt versions apparently,
which I've fixed and it is no longer needed.

Sorry about that.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
radare2-cutter: don't wrap, shouldn't be needed (and might be wrong)
b30a690 
This was working around mixed qt versions apparently,
which I've fixed and it is no longer needed.

Sorry about that.
@dtzWill dtzWill mentioned this pull request Jul 12, 2018
Merged
9 tasks
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2-cutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@dtzWill dtzWill merged commit 68cd907 into NixOS:master Jul 12, 2018
@dtzWill dtzWill deleted the fix/r2-cutter-no-wrapper branch July 12, 2018 18:25
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: radare2-cutter

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/5a9xali9bfy06kv2zwkxmk6hh29jbi3y-radare2-cutter-1.5
shrinking /nix/store/5a9xali9bfy06kv2zwkxmk6hh29jbi3y-radare2-cutter-1.5/bin/Cutter
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5a9xali9bfy06kv2zwkxmk6hh29jbi3y-radare2-cutter-1.5/bin
patching script interpreter paths in /nix/store/5a9xali9bfy06kv2zwkxmk6hh29jbi3y-radare2-cutter-1.5
checking for references to /build in /nix/store/5a9xali9bfy06kv2zwkxmk6hh29jbi3y-radare2-cutter-1.5...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/5a9xali9bfy06kv2zwkxmk6hh29jbi3y-radare2-cutter-1.5

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: radare2-cutter

Partial log (click to expand)

[6972/16620] CXX obj/third_party/webrtc/rtc_base/rtc_base_generic/crc32.o
[6973/16620] CXX obj/third_party/webrtc/pc/rtc_pc_base/srtptransport.o
[6974/16620] CXX obj/third_party/webrtc/rtc_base/rtc_base_approved_generic/platform_thread.o
[6975/16620] STAMP obj/third_party/webrtc/rtc_base/sanitizer.stamp
[6976/16620] CXX obj/third_party/webrtc/rtc_base/rtc_base_approved_generic/file_posix.o
[6977/16620] CXX obj/third_party/webrtc/p2p/rtc_p2p/icetransportinternal.o
[6978/16620] CXX obj/third_party/webrtc/pc/rtc_pc_base/channelmanager.o
building of '/nix/store/9xhc0p79i75c1qbaf4mi9wz78b3x209c-qtwebengine-5.11.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/2hj86vpkkkn44lz1kwg121w54b4bj0k0-radare2-cutter-1.5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2hj86vpkkkn44lz1kwg121w54b4bj0k0-radare2-cutter-1.5.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg