Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jmol: 14.29.12 -> 14.29.17 #43429

Merged
merged 1 commit into from Jul 12, 2018
Merged

jmol: 14.29.12 -> 14.29.17 #43429

merged 1 commit into from Jul 12, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Jul 12, 2018

Motivation for this change

Simple version bump. Also simplifies the version attribute so that @r-ryantm hopefully can deal with that now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: jmol

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: jmol

Partial log (click to expand)

  inflating: /nix/store/sva3k3xb9wz75j2pwxwbh3iazaaqkyl7-jmol-14.29.17/share/jsmol/testsave.htm
  inflating: /nix/store/sva3k3xb9wz75j2pwxwbh3iazaaqkyl7-jmol-14.29.17/share/jsmol/validation.htm
  inflating: /nix/store/sva3k3xb9wz75j2pwxwbh3iazaaqkyl7-jmol-14.29.17/share/jsmol/vibrate.htm
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/sva3k3xb9wz75j2pwxwbh3iazaaqkyl7-jmol-14.29.17/bin
patching script interpreter paths in /nix/store/sva3k3xb9wz75j2pwxwbh3iazaaqkyl7-jmol-14.29.17
/nix/store/sva3k3xb9wz75j2pwxwbh3iazaaqkyl7-jmol-14.29.17/bin/jmol: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/sva3k3xb9wz75j2pwxwbh3iazaaqkyl7-jmol-14.29.17/share/jmol/jmol.sh: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/sva3k3xb9wz75j2pwxwbh3iazaaqkyl7-jmol-14.29.17

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jmol

Partial log (click to expand)

  inflating: /nix/store/69jaxn3v9a3858d5m3lbmcg0li05s3g8-jmol-14.29.17/share/jsmol/validation.htm  
  inflating: /nix/store/69jaxn3v9a3858d5m3lbmcg0li05s3g8-jmol-14.29.17/share/jsmol/vibrate.htm  
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/69jaxn3v9a3858d5m3lbmcg0li05s3g8-jmol-14.29.17
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/69jaxn3v9a3858d5m3lbmcg0li05s3g8-jmol-14.29.17/bin 
patching script interpreter paths in /nix/store/69jaxn3v9a3858d5m3lbmcg0li05s3g8-jmol-14.29.17
/nix/store/69jaxn3v9a3858d5m3lbmcg0li05s3g8-jmol-14.29.17/bin/jmol: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/69jaxn3v9a3858d5m3lbmcg0li05s3g8-jmol-14.29.17/share/jmol/jmol.sh: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
checking for references to /tmp/nix-build-jmol-14.29.17.drv-0 in /nix/store/69jaxn3v9a3858d5m3lbmcg0li05s3g8-jmol-14.29.17...

@xeji xeji merged commit d37c23c into NixOS:master Jul 12, 2018
@timokau timokau deleted the jmol-14.29.17 branch July 12, 2018 20:49
@ryantm
Copy link
Member

ryantm commented Jul 13, 2018

Those version changes should definitely help. I consulted the logs and it was getting stuck at that part.

@timokau
Copy link
Member Author

timokau commented Jul 13, 2018

Great! I originally chose this version because I feared too much nix magic would deter potential contributors. But I think in this case it is worth it.

Is the source code of your bot public by the way? I looked for it to figure out what changes it can make, but I didn't find it. If it is, maybe it would be a good idea to link to it from its profile, like ofBorg does.

@ryantm
Copy link
Member

ryantm commented Jul 13, 2018

Yes, the source code is public. Here is the line where jmol was failing https://github.com/ryantm/nixpkgs-update/blob/5cf1bc67aa1165ab44df1091df84107688d4253e/src/Update.hs#L141

@timokau
Copy link
Member Author

timokau commented Jul 13, 2018

Okay thanks. As I said, I think linking that on r-ryantm's profile would be nice.

@ryantm
Copy link
Member

ryantm commented Jul 13, 2018

Thanks for the suggestion. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @GrahamcOfBorg @ryantm @xeji