New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aerospike: init at 4.2.0.4 #43428
aerospike: init at 4.2.0.4 #43428
Conversation
@volth do you know why the build is failing? I only see |
@volth can we get this merged? |
alright, maybe @adisbladis can help to merge this? |
Thanks! Code looks fine. 👍 Please fix up the commit messages and/or squash some of them. |
@fpletz done, PTAL. BTW, why don't you always Squash merge PRs? It makes the master branch a lot cleaner. |
Well, I didn't squash this because I was hoping you would combine all those fixup commits into sensible, topical commits that would retain the authorship from both of you. Maybe add at least a co-authored-by? |
Co-authored-by: Volth <volth@webmaster.ms>
Yeah, for every line it is too much but in general we like the work of other's to be properly attributed to them. Not only for being able to ask the author about their code but out of politeness. Also please not that I could've for instance added the co-authored-by myself and I regularly do so on trivial issues, but in his case I wanted both of your feedback first. Thanks! 👍 |
Motivation for this change
A NoSQL database.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)This was originally filed by @volth in #26855.