Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpoly: 0.1.5 -> 0.1.7 (noop), cleanup a bit to modern style #43441

Merged
merged 1 commit into from Jul 12, 2018
Merged

libpoly: 0.1.5 -> 0.1.7 (noop), cleanup a bit to modern style #43441

merged 1 commit into from Jul 12, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 12, 2018

Noticed update and started updating this before realized
the update is really a no-op.

Proposing we update anyway so I (or someone else) don't
make this mistake again :P and because there's no harm.

Only in-tree user is yices, so very small amount of rebuild :).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill force-pushed the update/libpoly-but-really-just-cleanup-a-bit branch from 34cb7ab to d3a595f Compare July 12, 2018 22:07
@dtzWill
Copy link
Member Author

dtzWill commented Jul 12, 2018

(touched up commit to leave 'python' as buildInput since it's used for bindings -- at least it would be if they were packaged, which they probably aren't? :P)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libpoly

Partial log (click to expand)

-- Installing: /nix/store/xy5fg4d5y727wx6v48qqp46qcm7qmzvv-libpoly-0.1.7/include/poly/variable_order.h
-- Installing: /nix/store/xy5fg4d5y727wx6v48qqp46qcm7qmzvv-libpoly-0.1.7/include/poly/version.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xy5fg4d5y727wx6v48qqp46qcm7qmzvv-libpoly-0.1.7
shrinking /nix/store/xy5fg4d5y727wx6v48qqp46qcm7qmzvv-libpoly-0.1.7/lib/libpoly.so.0.1.7
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xy5fg4d5y727wx6v48qqp46qcm7qmzvv-libpoly-0.1.7/lib
patching script interpreter paths in /nix/store/xy5fg4d5y727wx6v48qqp46qcm7qmzvv-libpoly-0.1.7
checking for references to /build in /nix/store/xy5fg4d5y727wx6v48qqp46qcm7qmzvv-libpoly-0.1.7...
/nix/store/xy5fg4d5y727wx6v48qqp46qcm7qmzvv-libpoly-0.1.7

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libpoly

Partial log (click to expand)

-- Installing: /nix/store/95ll9dg73n3hx6cm0pc1rr0s52mv3y7c-libpoly-0.1.7/include/poly/value.h
-- Installing: /nix/store/95ll9dg73n3hx6cm0pc1rr0s52mv3y7c-libpoly-0.1.7/include/poly/variable_db.h
-- Installing: /nix/store/95ll9dg73n3hx6cm0pc1rr0s52mv3y7c-libpoly-0.1.7/include/poly/variable_list.h
-- Installing: /nix/store/95ll9dg73n3hx6cm0pc1rr0s52mv3y7c-libpoly-0.1.7/include/poly/variable_order.h
-- Installing: /nix/store/95ll9dg73n3hx6cm0pc1rr0s52mv3y7c-libpoly-0.1.7/include/poly/version.h
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/95ll9dg73n3hx6cm0pc1rr0s52mv3y7c-libpoly-0.1.7/lib
patching script interpreter paths in /nix/store/95ll9dg73n3hx6cm0pc1rr0s52mv3y7c-libpoly-0.1.7
/nix/store/95ll9dg73n3hx6cm0pc1rr0s52mv3y7c-libpoly-0.1.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libpoly

Partial log (click to expand)

-- Installing: /nix/store/ql2n9b1x4bgbg3i0mhv1h3pm88m79dbw-libpoly-0.1.7/include/poly/variable_order.h
-- Installing: /nix/store/ql2n9b1x4bgbg3i0mhv1h3pm88m79dbw-libpoly-0.1.7/include/poly/version.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ql2n9b1x4bgbg3i0mhv1h3pm88m79dbw-libpoly-0.1.7
shrinking /nix/store/ql2n9b1x4bgbg3i0mhv1h3pm88m79dbw-libpoly-0.1.7/lib/libpoly.so.0.1.7
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ql2n9b1x4bgbg3i0mhv1h3pm88m79dbw-libpoly-0.1.7/lib
patching script interpreter paths in /nix/store/ql2n9b1x4bgbg3i0mhv1h3pm88m79dbw-libpoly-0.1.7
checking for references to /build in /nix/store/ql2n9b1x4bgbg3i0mhv1h3pm88m79dbw-libpoly-0.1.7...
/nix/store/ql2n9b1x4bgbg3i0mhv1h3pm88m79dbw-libpoly-0.1.7

@dtzWill
Copy link
Member Author

dtzWill commented Jul 12, 2018

@GrahamcOfBorg build yices

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yices

Partial log (click to expand)

shrinking /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0/bin/yices-smt
shrinking /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0/bin/yices-sat
shrinking /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0/bin/yices
shrinking /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0/bin/yices-smt2
shrinking /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0/lib/libyices.so.2.6.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0/lib  /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0/bin
patching script interpreter paths in /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0
checking for references to /build in /nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0...
/nix/store/hb26s74cdnjzv8n0jgv0z4qa2yidr357-yices-2.6.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: yices

Partial log (click to expand)

/nix/store/5q51r2d0xzs4hi8rb661drpf83mhm4b4-coreutils-8.29/bin/install -c -m 664 build/x86_64-apple-darwin16.3.0-release/dist/include/* /nix/store/kvp24xbpjja1dir7zk1168aj1d2642ai-yices-2.6.0/include
/nix/store/5q51r2d0xzs4hi8rb661drpf83mhm4b4-coreutils-8.29/bin/install -c build/x86_64-apple-darwin16.3.0-release/dist/bin/* /nix/store/kvp24xbpjja1dir7zk1168aj1d2642ai-yices-2.6.0/bin
/nix/store/5q51r2d0xzs4hi8rb661drpf83mhm4b4-coreutils-8.29/bin/install -c build/x86_64-apple-darwin16.3.0-release/dist/lib/* /nix/store/kvp24xbpjja1dir7zk1168aj1d2642ai-yices-2.6.0/lib
(cd /nix/store/kvp24xbpjja1dir7zk1168aj1d2642ai-yices-2.6.0/lib && ln -s -f libyices.2.dylib libyices.dylib)
make[1]: Leaving directory '/private/tmp/nix-build-yices-2.6.0.drv-0/yices2-Yices-2.6.0'
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kvp24xbpjja1dir7zk1168aj1d2642ai-yices-2.6.0/lib  /nix/store/kvp24xbpjja1dir7zk1168aj1d2642ai-yices-2.6.0/bin
patching script interpreter paths in /nix/store/kvp24xbpjja1dir7zk1168aj1d2642ai-yices-2.6.0
/nix/store/kvp24xbpjja1dir7zk1168aj1d2642ai-yices-2.6.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: yices

Partial log (click to expand)

shrinking /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0/lib/libyices.so.2.6.0
shrinking /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0/bin/yices-smt2
shrinking /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0/bin/yices-smt
shrinking /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0/bin/yices-sat
shrinking /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0/bin/yices
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0/lib  /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0/bin
patching script interpreter paths in /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0
checking for references to /build in /nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0...
/nix/store/rl1d219j4fhh21whxgl7cc9k3yvi62hs-yices-2.6.0

@dtzWill dtzWill merged commit c78b0ef into NixOS:master Jul 12, 2018
@dtzWill dtzWill deleted the update/libpoly-but-really-just-cleanup-a-bit branch July 12, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg