Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cozy #43437

Merged
merged 5 commits into from Aug 31, 2018
Merged

Cozy #43437

merged 5 commits into from Aug 31, 2018

Conversation

MostAwesomeDude
Copy link
Contributor

@MostAwesomeDude MostAwesomeDude commented Jul 12, 2018

Motivation for this change

I want to play with Cozy. I needed #42603.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

'';

meta = {
homepage = http://igraph.org/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description.


meta = {
description = "Dict implementations with attribute access";
maintainers = [ lib.maintainers.MostAwesomeDude ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the license.


meta = {
description = "High performance graph data structures and algorithms";
maintainers = [ lib.maintainers.MostAwesomeDude ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the license.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split f6f2b38ec9e04c2a0efc778b4fec39b9fef2971c over the commits that you modified.

@FRidh
Copy link
Member

FRidh commented Jul 21, 2018

@GrahamcOfBorg build python.pkgs.dictionaries python3.pkgs.dictionaries python.pkgs.python-igraph python3.pkgs.python-igraph

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python.pkgs.dictionaries, python3.pkgs.dictionaries, python.pkgs.python-igraph, python3.pkgs.python-igraph

Partial log (click to expand)

OK (skipped=3)
Build type: dynamic extension
Include path: /nix/store/6rplnff2srswj95563hpp4f5ssqbnw7j-igraph/include/igraph
Library path: /nix/store/6rplnff2srswj95563hpp4f5ssqbnw7j-igraph/lib
Runtime library path:
Linked dynamic libraries: igraph
Linked static libraries:
Extra compiler options:
Extra linker options:
error: build of '/nix/store/774q9djcz0xq9dxhcfrwq22g4y8j12m7-python3.6-dictionaries-0.0.1.drv', '/nix/store/hbqy4nqrxqnw8jwm91dh7yjfyki8y9g8-python2.7-dictionaries-0.0.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python.pkgs.dictionaries, python3.pkgs.dictionaries, python.pkgs.python-igraph, python3.pkgs.python-igraph

Partial log (click to expand)

Library path: /nix/store/1ph06dcq5mdsa7wg745cwvvrw2ykh6s9-igraph/lib
Runtime library path:
Linked dynamic libraries: igraph
Linked static libraries:
Extra compiler options:
Extra linker options:
/nix/store/ng1dbsfhg7c63mfwmf37m6s4lzlddpyj-python2.7-dictionaries-0.0.1
/nix/store/b8avxjwkzgjfd1xsqisqnjk31dpssi6l-python3.6-dictionaries-0.0.1
/nix/store/m7srpscpr5yn6cj3x5qbj3xwlssn30j2-python2.7-python-igraph-0.7.1.post6
/nix/store/rmn24m4dmaxzrimr05072y9w3qrkn250-python3.6-python-igraph-0.7.1.post6

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python.pkgs.dictionaries, python3.pkgs.dictionaries, python.pkgs.python-igraph, python3.pkgs.python-igraph

Partial log (click to expand)

OK (skipped=3)
Build type: dynamic extension
Include path: /nix/store/f4vz2rkknkq9bjs8dkxp7di1qxqhsp5y-igraph/include/igraph
Library path: /nix/store/f4vz2rkknkq9bjs8dkxp7di1qxqhsp5y-igraph/lib
Runtime library path:
Linked dynamic libraries: igraph
Linked static libraries:
Extra compiler options:
Extra linker options:
error: build of '/nix/store/nn38yzsax0adigx7wbqb188dv09z1wx4-python2.7-dictionaries-0.0.1.drv', '/nix/store/vxnfqc15113m2f8yygfh08pmrbwzfijg-python3.6-dictionaries-0.0.1.drv' failed

@MostAwesomeDude
Copy link
Contributor Author

FWIW I just want to indicate that I am still alive on this branch and ready for re-review at any time.

@FRidh
Copy link
Member

FRidh commented Aug 19, 2018

@GrahamcOfBorg build python.pkgs.dictionaries python3.pkgs.dictionaries python.pkgs.python-igraph python3.pkgs.python-igraph

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python.pkgs.dictionaries, python3.pkgs.dictionaries, python.pkgs.python-igraph, python3.pkgs.python-igraph

Partial log (click to expand)

Library path: /nix/store/qlxbngb0g3nb1raxj6z01091w69r67xx-igraph/lib
Runtime library path:
Linked dynamic libraries: igraph
Linked static libraries:
Extra compiler options:
Extra linker options:
/nix/store/zmxpwcagg1x9iady4lr8pmjldk5rl5k6-python2.7-dictionaries-0.0.1
/nix/store/id43b0rb143m7hwslsacanjgdsi5qch6-python3.6-dictionaries-0.0.1
/nix/store/lmyibb4i8ib4p65wpasm0fwf8cfkm662-python2.7-python-igraph-0.7.1.post6
/nix/store/86fjmn52ja8xgzby107405fwhd66alsi-python3.6-python-igraph-0.7.1.post6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python.pkgs.dictionaries, python3.pkgs.dictionaries, python.pkgs.python-igraph, python3.pkgs.python-igraph

Partial log (click to expand)

Library path: /nix/store/w3f7050nlzg438yyy018i8732cbzb1j0-igraph/lib
Runtime library path:
Linked dynamic libraries: igraph
Linked static libraries:
Extra compiler options:
Extra linker options:
/nix/store/g161774fwg9lhzfkwyf875vl0bgq33wi-python2.7-dictionaries-0.0.1
/nix/store/w7x17cilidkapd1h7ngm88d5gy3kl6zp-python3.6-dictionaries-0.0.1
/nix/store/2m1zdl4nkkmn3fskcabmi79sgbf21zra-python2.7-python-igraph-0.7.1.post6
/nix/store/63bx9mga59hldwdrkpq4j963fw2a23dl-python3.6-python-igraph-0.7.1.post6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python.pkgs.dictionaries, python3.pkgs.dictionaries, python.pkgs.python-igraph, python3.pkgs.python-igraph

Partial log (click to expand)

Library path: /nix/store/lb73dadw1m9jph338yx83dqkh21kx07f-igraph/lib
Runtime library path:
Linked dynamic libraries: igraph
Linked static libraries:
Extra compiler options:
Extra linker options:
/nix/store/wzhv4s245r0v2gmqz3nk6gyx4r23csyv-python2.7-dictionaries-0.0.1
/nix/store/ivf2n0kid3prsh35xkbv8jxqgg6jrd75-python3.6-dictionaries-0.0.1
/nix/store/8gml0h36fjp82ij4frzi928p4yxmv6lh-python2.7-python-igraph-0.7.1.post6
/nix/store/fg0iz5wij3dsxiks8bshqdzlyzrq47zp-python3.6-python-igraph-0.7.1.post6

@Ekleog
Copy link
Member

Ekleog commented Aug 31, 2018

(triage) I think this is ready to merge?

@infinisil infinisil merged commit f7606a8 into NixOS:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants