Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.aws-adfs: init at 0.12.0 #43458

Merged
merged 2 commits into from Jul 15, 2018
Merged

pythonPackages.aws-adfs: init at 0.12.0 #43458

merged 2 commits into from Jul 15, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jul 13, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple bhipple requested a review from FRidh as a code owner July 13, 2018 02:58
@bhipple
Copy link
Contributor Author

bhipple commented Jul 13, 2018

@GrahamcOfBorg build python2Packages.aws-adfs python3Packages.aws-adfs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.aws-adfs, python3Packages.aws-adfs

Partial log (click to expand)

/tmp/nix-build-python3.6-aws-adfs-0.12.0.drv-0/aws-adfs-0.12.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6f4sfsbi1b0q0asri0f0gd1kp074awhd-python3.6-aws-adfs-0.12.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6f4sfsbi1b0q0asri0f0gd1kp074awhd-python3.6-aws-adfs-0.12.0/lib  /nix/store/6f4sfsbi1b0q0asri0f0gd1kp074awhd-python3.6-aws-adfs-0.12.0/bin 
patching script interpreter paths in /nix/store/6f4sfsbi1b0q0asri0f0gd1kp074awhd-python3.6-aws-adfs-0.12.0
checking for references to /tmp/nix-build-python3.6-aws-adfs-0.12.0.drv-0 in /nix/store/6f4sfsbi1b0q0asri0f0gd1kp074awhd-python3.6-aws-adfs-0.12.0...
wrapping `/nix/store/6f4sfsbi1b0q0asri0f0gd1kp074awhd-python3.6-aws-adfs-0.12.0/bin/aws-adfs'...
/nix/store/knbs991sk33vngkfv3nji01b0wnnb79l-python2.7-aws-adfs-0.12.0
/nix/store/6f4sfsbi1b0q0asri0f0gd1kp074awhd-python3.6-aws-adfs-0.12.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.aws-adfs, python3Packages.aws-adfs

Partial log (click to expand)

test/test_authenticator.py .....                                         [ 56%]
test/test_click_parses_command_line_arguments.py .                       [ 60%]
test/test_config_preparation.py ..                                       [ 66%]
test/test_fetch_html_encoded_roles.py ..                                 [ 73%]
test/test_role_chooser.py .......                                        [ 96%]
test/test_version.py .                                                   [100%]

========================== 30 passed in 2.14 seconds ===========================
/nix/store/49nnj6p14h1xp150y3n1gzh52s7z2kwz-python2.7-aws-adfs-0.12.0
/nix/store/w0yx860l9vs93j1n5bs3935k08pqpqb2-python3.6-aws-adfs-0.12.0

bhipple
bhipple commented Jul 13, 2018
View reviewed changes
pkgs/development/python-modules/aws-adfs/default.nix Outdated
propagatedBuildInputs = [ lxml boto3 requests click configparser ];

# Python3 tests fail with UTF-8 issues due to click
doCheck = !isPy3k;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click also has quite a few python3 UTF-8 errors in its own test suite, but it happens to be disabled at the moment. It looks like they're preparing a click 7.0 which might fix a handful of locale issues, but 6.7 is still the latest one available as of now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have luck with adding glibcLocales to checkInputs and setting LC_ALL = "en_US.UTF-8".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I was setting LC_ALL but passing locale to checkInputs; thanks for the tip! It works now.

dotlambda
dotlambda reviewed Jul 13, 2018
View reviewed changes
pkgs/development/python-modules/aws-adfs/default.nix Outdated
@@ -0,0 +1,33 @@
{ lib, buildPythonPackage, fetchPypi, pythonPackages, isPy3k
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no pythonPackages

@bhipple
Copy link
Contributor Author

bhipple commented Jul 15, 2018

@GrahamcOfBorg build python2Packages.aws-adfs python3Packages.aws-adfs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.aws-adfs, python3Packages.aws-adfs

Partial log (click to expand)

test/test_authenticator.py .....                                         [ 56%]
test/test_click_parses_command_line_arguments.py .                       [ 60%]
test/test_config_preparation.py ..                                       [ 66%]
test/test_fetch_html_encoded_roles.py ..                                 [ 73%]
test/test_role_chooser.py .......                                        [ 96%]
test/test_version.py .                                                   [100%]

========================== 30 passed in 0.60 seconds ===========================
/nix/store/s5yf2aajy9dwwv15zmjzqb415i969w9j-python2.7-aws-adfs-0.12.0
/nix/store/lhflrjdiyj5klkwrwbxwzvx8y72gp441-python3.6-aws-adfs-0.12.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.aws-adfs, python3Packages.aws-adfs

Partial log (click to expand)

test/test_authenticator.py .....                                         [ 56%]
test/test_click_parses_command_line_arguments.py .                       [ 60%]
test/test_config_preparation.py ..                                       [ 66%]
test/test_fetch_html_encoded_roles.py ..                                 [ 73%]
test/test_role_chooser.py .......                                        [ 96%]
test/test_version.py .                                                   [100%]

========================== 30 passed in 2.98 seconds ===========================
/nix/store/24srk11yjbr9qxw4i7gkbdlnq72y7c3a-python2.7-aws-adfs-0.12.0
/nix/store/qn7xjf3f6b6sval7bkjqaf8pypfrnkhy-python3.6-aws-adfs-0.12.0

@dotlambda dotlambda merged commit dab1b67 into NixOS:master Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @dotlambda