Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s4cmd: init at 2.0.1 #43459

Merged
merged 1 commit into from Jul 15, 2018
Merged

s4cmd: init at 2.0.1 #43459

merged 1 commit into from Jul 15, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jul 13, 2018 •
edited

Tool for interacting with S3 buckets, with some performance optimizations over s3cmd.

Skips installing the bash shell completion scripts in /etc, to work around:
#4968
pypa/setuptools#130

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple
s4cmd: init at 2.0.1
47dfba8 
Tool for interacting with S3 buckets, with some performance optimizations over s3cmd.

Skips installing the bash shell completion scripts in /etc, to work around:
NixOS#4968
pypa/setuptools#130
@bhipple
Copy link
Contributor Author

bhipple commented Jul 13, 2018

@GrahamcOfBorg build s4cmd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: s4cmd

Partial log (click to expand)

Successfully installed s4cmd-2.0.1
/tmp/nix-build-s4cmd-2.0.1.drv-0/s4cmd-2.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sb491z9c96si534nswwwgf1pn3yjs770-s4cmd-2.0.1
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sb491z9c96si534nswwwgf1pn3yjs770-s4cmd-2.0.1/lib  /nix/store/sb491z9c96si534nswwwgf1pn3yjs770-s4cmd-2.0.1/bin 
patching script interpreter paths in /nix/store/sb491z9c96si534nswwwgf1pn3yjs770-s4cmd-2.0.1
checking for references to /tmp/nix-build-s4cmd-2.0.1.drv-0 in /nix/store/sb491z9c96si534nswwwgf1pn3yjs770-s4cmd-2.0.1...
wrapping `/nix/store/sb491z9c96si534nswwwgf1pn3yjs770-s4cmd-2.0.1/bin/s4cmd.py'...
/nix/store/sb491z9c96si534nswwwgf1pn3yjs770-s4cmd-2.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: s4cmd

Partial log (click to expand)

Successfully installed s4cmd-2.0.1
/build/s4cmd-2.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1/lib  /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1/bin
patching script interpreter paths in /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1
checking for references to /build in /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1...
wrapping `/nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1/bin/s4cmd.py'...
/nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1

bhipple
bhipple commented Jul 13, 2018
View reviewed changes
pkgs/tools/networking/s4cmd/default.nix
@@ -0,0 +1,35 @@
{ stdenv, python3Packages }:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh this application works and has support for both python2 and python3; should I set this as pythonPackages and let it float to that alias, or should I advertise that it works with python3 as above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any point to running it under python2? It's fine as it is now imo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key point is not what it runs now, but to show that it is compatible with both. This is/was important for the whole 2 to 3 migration. But, as that's not really happening I don't care much anymore.

Copy link
Contributor Author

@bhipple bhipple Jul 15, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll leave it as python3Packages then, since that very clearly shows it's compatible with python3, and is unlikely to have support dropped by upstream anytime soon.

Is there an issue/RFC/ticket/PR discussing some of the 2 to 3 migration plans/strategies/thoughts? Curious to learn more. Seems like we can just follow whatever upstream does for individual packages without having to take initiative ourselves.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: s4cmd

Partial log (click to expand)

/nix/store/sb491z9c96si534nswwwgf1pn3yjs770-s4cmd-2.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: s4cmd

Partial log (click to expand)

Successfully installed s4cmd-2.0.1
/build/s4cmd-2.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1/lib  /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1/bin
patching script interpreter paths in /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1
checking for references to /build in /nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1...
wrapping `/nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1/bin/s4cmd.py'...
/nix/store/y6mz44hl9cfiwzdj53d4x6j5w6fbz682-s4cmd-2.0.1

@bhipple
Copy link
Contributor Author

bhipple commented Jul 15, 2018

This one should be good to go

@adisbladis adisbladis merged commit b23a243 into NixOS:master Jul 15, 2018
@adisbladis
Copy link
Member

Thanks! :)

@bhipple bhipple deleted the add/s4cmd branch July 21, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @GrahamcOfBorg @adisbladis @FRidh