nixos/switch-to-configuration: Never stop system.slice #43682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @edolstra @ocharles (since you've contributed the most to switch-to-configuration.pl) Is this change ok? I've tried to keep it as minimal as possible to avoid further bugs. Running Edit: I've initially set the wrong branch, this should go into master (and 18.09), but we should probably also backport it to 18.03 in case we upgrade the systemd version. |
Problem: Restarting (stopping) system.slice would not only stop X11 but also most system units/services. We obviously don't want this happening to users when they switch from 18.03 to 18.09 or nixos-unstable. Reason: The following change in systemd: systemd/systemd@d8e5a93 The commit adds system.slice to the perpetual units, which means removing the unit file and adding it to the source code. This is done so that system.slice can't be stopped anymore but in our case it ironically would cause this script to stop system.slice because the unit file was removed (and an older systemd version is still running). Related issue: NixOS#39791
primeos
force-pushed
the
never-stop-system.slice
branch
from
6e82f17
to
7098b0f
Compare
primeos
added
0.kind: bug
9.needs: port to stable
matthewbauer
approved these changes
Jul 21, 2018
|
(Merged it since there where no objections, the change is minimal, and we could revert it at any time.) @matthewbauer: Thank you very much for your review :) |
KiaraGrouwstra
added a commit
to KiaraGrouwstra/nix-config
that referenced
this pull request
Aug 18, 2018
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Problem: Restarting (stopping) system.slice would not only stop X11 but
also most system units/services. We obviously don't want this happening
to users when they switch from 18.03 to 18.09 or nixos-unstable.
Reason: The following change in systemd:
systemd/systemd@d8e5a93
The commit adds system.slice to the perpetual units, which means
removing the unit file and adding it to the source code. This is done so
that system.slice can't be stopped anymore but in our case it ironically
would cause this script to stop system.slice because the unit file was
removed (and an older systemd version is still running).
Related issue: #39791
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)