Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "unixtools: link instead of copying" #43683

Closed
wants to merge 1 commit into from
Closed

Revert "unixtools: link instead of copying" #43683

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 17, 2018

This reverts commit f1a14f9.

Fixes #43650. Haven't investigated "why" but let's get things working.

At least gets things as far as "extra-utils", which it doesn't now.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Yeah this is definitely fine if it fixes something that is broken. preferLocalBuild can maybe? be left in though (not sure what the advantages/disadvantages are of this).

@dtzWill
Copy link
Member Author

dtzWill commented Jul 17, 2018

@GrahamcOfBorg test bind

Fingers crossed that maybe the glorious aarch64 builder makes it 😁.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 17, 2018

Hmm, maybe not? I think things are okay now? 😁

Sorry for false alarm :).

@dtzWill dtzWill closed this Jul 17, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.bind

Partial log (click to expand)

cannot build derivation '/nix/store/mx32lyal937p72cab3aks6lj9rl39j7a-user-units.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/h5dyw9bn5yb1g0x3jmpv5nz8adjidghc-etc.drv': 6 dependencies couldn't be built
building '/nix/store/804rgrdwzqbm3qz361bprs0px75591mv-install-grub.sh.drv'...
cannot build derivation '/nix/store/f58jfz2ydd10xffldfgwllks4100hafp-nixos-system-machine-18.09.git.1af33e1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/lxk8qv4wd906fvl3ajhxwkdg31qlg4db-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3b4p12pq6463r55hbdxyw34j48130g14-run-nixos-vm.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/k5hl19d7mrg859nsly9y6sv8n3xrwx6q-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/b5j00glfsnssjxj49hi9mxgq7k21jif0-nixos-test-driver-bind.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/f625h5r9c7i1d6gk4avsv5sw16pk0ysj-vm-test-run-bind.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f625h5r9c7i1d6gk4avsv5sw16pk0ysj-vm-test-run-bind.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.bind

Partial log (click to expand)

machine: running command: sync
machine# [   17.825141] dhcpcd[755]: eth0: Router Advertisement from fe80::2
machine# [   17.830336] dhcpcd[755]: eth0: adding address fec0::5054:ff:fe12:3456/64
machine: exit status 0
test script finished in 18.79s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/zg6l781f7dgkx7wmfvyhjx6ifdy8sf6a-vm-test-run-bind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @matthewbauer @GrahamcOfBorg