Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python36: 3.6.5 -> 3.6.6 #43667

Merged
merged 1 commit into from Jul 21, 2018
Merged

python36: 3.6.5 -> 3.6.6 #43667

merged 1 commit into from Jul 21, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jul 17, 2018

(cherry picked from commit 78e0521)

Needs testing on Darwin, cc @NixOS/darwin-maintainers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
python36: 3.6.5 -> 3.6.6
634c7e6 
(cherry picked from commit 78e0521)
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36

Partial log (click to expand)

strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6/lib  /nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6/bin
patching script interpreter paths in /nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6
/nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6/bin/python3.6m-config: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6/lib/python3.6/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6/lib/python3.6/config-3.6m-x86_64-linux-gnu/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6/lib/python3.6/config-3.6m-x86_64-linux-gnu/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6...
wrong ELF type
/nix/store/bm00isqn4wbw4g1dk68llvjzl8jp37yj-python3-3.6.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36

Partial log (click to expand)

/nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6/lib/python3.6/test/test_support.py
post-installation fixup
gzipping man pages under /nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6/share/man/
strip is /nix/store/q4mjflkrrpvajlawjngyr0d1bhpyb5ij-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6/lib  /nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6/bin
patching script interpreter paths in /nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6
/nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6/lib/python3.6/config-3.6m-darwin/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/k5n19ccijsqdi5dwgblcck8x6b7ymlml-bash-4.4-p12/bin/sh"
/nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6/lib/python3.6/config-3.6m-darwin/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/k5n19ccijsqdi5dwgblcck8x6b7ymlml-bash-4.4-p12/bin/sh"
/nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6/lib/python3.6/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/k5n19ccijsqdi5dwgblcck8x6b7ymlml-bash-4.4-p12/bin/sh"
/nix/store/86323jvlz5djknl6fraljzqg48w4g9hi-python3-3.6.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36

Partial log (click to expand)

strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6/lib  /nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6/bin
patching script interpreter paths in /nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6
/nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6/lib/python3.6/config-3.6m-aarch64-linux-gnu/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6/lib/python3.6/config-3.6m-aarch64-linux-gnu/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6/lib/python3.6/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6/bin/python3.6m-config: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6...
wrong ELF type
/nix/store/jkzzk11h5vlx2pq10hx9sh3d36ls9f8p-python3-3.6.6

LnL7
LnL7 approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on darwin with a bunch of packages.

@FRidh
Copy link
Member Author

FRidh commented Jul 18, 2018

@vcunat should we use staging-18.03? As I don't expect any trouble I don't think it is necessary.

@FRidh FRidh merged commit 7ee55eb into NixOS:release-18.03 Jul 21, 2018
@FRidh FRidh deleted the 1803_python36 branch July 21, 2018 08:51
@vcunat
Copy link
Member

vcunat commented Jul 21, 2018

I'm late :-) but I don't feel strongly about staging-18.03 anyway, in this case and in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FRidh @GrahamcOfBorg @vcunat @LnL7