Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdocker: init at unstable-2018-07-17 #43686

Merged
merged 1 commit into from Nov 11, 2018
Merged

rdocker: init at unstable-2018-07-17 #43686

merged 1 commit into from Nov 11, 2018

Conversation

kliu128
Copy link

@kliu128 kliu128 commented Jul 17, 2018

Motivation for this change

rdocker is a tool for remote Docker socket forwarding.

Things done

Not sure if the wrapping with openssh is really necessary; rdocker.sh is just a bash script that calls ssh.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

nlewo
nlewo previously requested changes Jul 19, 2018
View reviewed changes
pkgs/development/tools/rdocker/default.nix Outdated Show resolved Hide resolved
@nlewo
Copy link
Member

nlewo commented Jul 20, 2018

@GrahamcOfBorg build rdocker

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rdocker

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9zb41kc88i14p4n35m6r5v0z6c3lfl2y-rdocker-unstable-2018-07-17
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9zb41kc88i14p4n35m6r5v0z6c3lfl2y-rdocker-unstable-2018-07-17/bin
patching script interpreter paths in /nix/store/9zb41kc88i14p4n35m6r5v0z6c3lfl2y-rdocker-unstable-2018-07-17
/nix/store/9zb41kc88i14p4n35m6r5v0z6c3lfl2y-rdocker-unstable-2018-07-17/bin/rdocker: interpreter directive changed from "/bin/bash" to "/nix/store/3swzdhnphnbxjcyx2bkk1gh9k8gi3kl6-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/9zb41kc88i14p4n35m6r5v0z6c3lfl2y-rdocker-unstable-2018-07-17...
/nix/store/9zb41kc88i14p4n35m6r5v0z6c3lfl2y-rdocker-unstable-2018-07-17

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rdocker

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kcr06vmi43rbpywpb3pzmm43yf2qbhlf-rdocker-unstable-2018-07-17
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kcr06vmi43rbpywpb3pzmm43yf2qbhlf-rdocker-unstable-2018-07-17/bin
patching script interpreter paths in /nix/store/kcr06vmi43rbpywpb3pzmm43yf2qbhlf-rdocker-unstable-2018-07-17
/nix/store/kcr06vmi43rbpywpb3pzmm43yf2qbhlf-rdocker-unstable-2018-07-17/bin/rdocker: interpreter directive changed from "/bin/bash" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/kcr06vmi43rbpywpb3pzmm43yf2qbhlf-rdocker-unstable-2018-07-17...
/nix/store/kcr06vmi43rbpywpb3pzmm43yf2qbhlf-rdocker-unstable-2018-07-17

@samueldr samueldr dismissed nlewo’s stale review November 11, 2018 22:40

Contributor made changes

@samueldr samueldr merged commit 9997a3d into NixOS:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo left review comments

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kliu128 @nlewo @GrahamcOfBorg @samueldr