Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdcc, gputils: add gputils #43673

Merged
merged 6 commits into from Jul 17, 2018
Merged

sdcc, gputils: add gputils #43673

merged 6 commits into from Jul 17, 2018

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

Currently, sdcc is built without gputils. This means it can't build for pic14 and pic16.
I added gputils, and added the dependencies needed for sdcc not to crash at runtime.
Also added a disabled argument for faster builds if you only need one architecture.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member

@GrahamcOfBorg build sdcc

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sdcc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

lukateras
lukateras previously requested changes Jul 17, 2018
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-free components in sdcc get compiled in when built with gputils. Do not merge yet.

@lukateras lukateras dismissed their stale review July 17, 2018 16:20

Resolved.

@lukateras
Copy link
Member

@GrahamcOfBorg build gputils sdcc

@yorickvP
Copy link
Contributor Author

Nice! Thanks!

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gputils, sdcc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sdcc

Partial log (click to expand)

shrinking /nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0/bin/sdas390
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0/bin
patching script interpreter paths in /nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0
/nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0/share/sdcc/non-free/lib/src/pic14/libdev/mkall.sh: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
/nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0/share/sdcc/non-free/lib/src/pic16/libdev/mkmk.sh: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
/nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0/share/sdcc/non-free/lib/src/pic16/libdev/testall.sh: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
/nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0/share/sdcc/lib/src/pic16/libio/mkmk.sh: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0...
/nix/store/h0jjh4fzw26aicjc2f45y8prhj4sh9sa-sdcc-3.7.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gputils, sdcc

Partial log (click to expand)

shrinking /nix/store/6gjja4d6yyyg5mis0n2q48j2hmzvpv3q-gputils-1.5.0-1/bin/gplib
shrinking /nix/store/6gjja4d6yyyg5mis0n2q48j2hmzvpv3q-gputils-1.5.0-1/bin/gpvc
shrinking /nix/store/6gjja4d6yyyg5mis0n2q48j2hmzvpv3q-gputils-1.5.0-1/bin/gpstrip
gzipping man pages under /nix/store/6gjja4d6yyyg5mis0n2q48j2hmzvpv3q-gputils-1.5.0-1/share/man/
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6gjja4d6yyyg5mis0n2q48j2hmzvpv3q-gputils-1.5.0-1/bin 
patching script interpreter paths in /nix/store/6gjja4d6yyyg5mis0n2q48j2hmzvpv3q-gputils-1.5.0-1
checking for references to /tmp/nix-build-gputils-1.5.0-1.drv-0 in /nix/store/6gjja4d6yyyg5mis0n2q48j2hmzvpv3q-gputils-1.5.0-1...
/nix/store/6gjja4d6yyyg5mis0n2q48j2hmzvpv3q-gputils-1.5.0-1
/nix/store/7qnwxb7f8k7j7l8sc197xrv2ng9s7swa-sdcc-3.7.0

@lukateras lukateras merged commit ffaf902 into NixOS:master Jul 17, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: sdcc

Partial log (click to expand)

../../../bin/sdcc -mr2k -I./../../include -I. --std-c99 -c ../wcscmp.c
../../../bin/sdcc -mr2k -I./../../include -I. --std-c99 -c ../wcslen.c
../../../bin/sdcc -mr2k -I./../../include -I. --std-c99 -c ../btowc.c
../../../bin/sdcc -mr2k -I./../../include -I. --std-c99 -c ../wctob.c
../../../bin/sdcc -mr2k -I./../../include -I. --std-c99 -c ../mbsinit.c
../../../bin/sdcc -mr2k -I./../../include -I. --std-c99 -c ../mbrlen.c
../../../bin/sdcc -mr2k -I./../../include -I. --std-c99 -c ../mbrtowc.c
../../../bin/sdcc -mr2k -I./../../include -I. --std-c99 -c ../wcrtomb.c
building of '/nix/store/i7ic9qy6mb2c8w3bw9kfjlpv503fr9id-sdcc-3.7.0.drv' timed out after 3600 seconds
error: build of '/nix/store/i7ic9qy6mb2c8w3bw9kfjlpv503fr9id-sdcc-3.7.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gputils, sdcc

Partial log (click to expand)

shrinking /nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0/bin/shc08
shrinking /nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0/bin/stlcs
shrinking /nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0/bin/sz80
shrinking /nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0/bin/s51
shrinking /nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0/bin/sdcdb
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0/bin
patching script interpreter paths in /nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0
/nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0/share/sdcc/lib/src/pic16/libio/mkmk.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3swzdhnphnbxjcyx2bkk1gh9k8gi3kl6-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/vr6pmsn5mcs58i04smddd4jyg5m767za-sdcc-3.7.0...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yorickvP @lukateras @GrahamcOfBorg