Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliases: (re)add forceSystem #43669

Merged
merged 1 commit into from Jul 18, 2018
Merged

Conversation

matthewbauer
Copy link
Member

Some uses of this still exist outside of Nixpkgs.

@grahamc
Copy link
Member

grahamc commented Jul 17, 2018

Looks good from here, I wonder, though, if we should just not deprecate it, if it is such a simple function and not doing weird contortions to continue working. What do you think?

@grahamc
Copy link
Member

grahamc commented Jul 17, 2018

Not sure you meant to add the recurseIntoAttrs to this PR?

@matthewbauer
Copy link
Member Author

Oops - yeah the recurseIntoAttrs was meant for a different branch.

I think x86_64-linux is the only instance where we do support building on another system (i686-linux). Otherwise for forceSystem to work you would need remote builders setup or to luck out and get if from the cache. So we definitely don't want Nixpkgs users to have to rely on that. That creates too much of a situation where it works for one person at one time but breaks for everyone else at other times.

I don't have any problem with people using something like this in their own configs but it's hard to separate the two out. I have opened #43692 that will make it a little easier to enforce this kind of thing. This would make it so that you can use the alias locally but on Hydra & OfBorg there will be an evaluation error.

/cc @Ericson2314

Some uses of this still exist outside of Nixpkgs
@matthewbauer matthewbauer merged commit 84a5808 into NixOS:master Jul 18, 2018
@matthewbauer
Copy link
Member Author

I got rid of the warning but will leave it in aliases.nix just to make it clear that it's not something we want people to be using directly as part of all-packages.nix

@matthewbauer matthewbauer deleted the readd-forceSystem branch February 22, 2019 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants