Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-modules: only include glibc locales when using glibc #43666

Merged
merged 1 commit into from Jul 17, 2018
Merged

haskell-modules: only include glibc locales when using glibc #43666

merged 1 commit into from Jul 17, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 17, 2018

Fixes #43665.
Hopefully. :)

cc @nh2 -- can you check if this fixes/helps the issue?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from peti as a code owner July 17, 2018 13:44
@nh2 nh2 mentioned this pull request Jul 17, 2018
Closed
@nh2
Copy link
Contributor

nh2 commented Jul 17, 2018

I can confirm this fixes #43665 for me.

@peti peti merged commit 464cf10 into NixOS:master Jul 17, 2018
@dtzWill dtzWill deleted the fix/haskell-glibc-locales-are-for-glibc branch July 17, 2018 16:16
@nh2 nh2 mentioned this pull request Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

callCabal2nix doesn't work with musl-native
4 participants
@dtzWill @nh2 @peti @GrahamcOfBorg