Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goBuildPackage: Add -x to the go build command if NIX_DEBUG >= 1 #43664

Merged
merged 1 commit into from Jul 24, 2018
Merged

goBuildPackage: Add -x to the go build command if NIX_DEBUG >= 1 #43664

merged 1 commit into from Jul 24, 2018

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Jul 17, 2018

The -x go option prints all intermediate commands used by the Go
compiler. For instance, this is pretty useful to debug Go LD_FLAGS
because the used linker command is printed.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

orivej
orivej reviewed Jul 17, 2018
View reviewed changes
pkgs/development/go-modules/generic/default.nix Outdated
@@ -151,6 +151,11 @@ go.stdenv.mkDerivation (
fi
}

export GO_X=""
if (( "''${NIX_DEBUG:-0}" >= 1 )); then
export GO_X="-x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't export the variable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use buildFlagsArray+=(-x) instead of the variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nlewo
goBuildPackage: Add -x to the go build command if NIX_DEBUG >= 1
05df6d4 
The -x go option prints all intermediate commands used by the Go
compiler. For instance, this is pretty useful to debug Go LD_FLAGS
because the used linker command is printed.
@nlewo nlewo merged commit c5f1eea into NixOS:staging Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlewo @orivej @GrahamcOfBorg