termite: factor wrapper out into its own file #43691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
force-pushed
the
refactor-termite-build
branch
from
b5c6df0
to
e9ef19d
Compare
Ma27
changed the title
|
File name |
|
you're actually right, the wrapped version should be in |
Until now it's impossible to override the attrs of the actual build
instruction for the `termite` package like this:
```
termite.overrideAttrs (_: {
# ...
})
```
This issue occurs since the `termite/default.nix` expressions returns
the `symlinkJoin` expression when I override termite (e.g. to provide a
config file).
I recently patched termite and wanted to apply this patch to my local
termite installation in my system config which is impossible this, so
splitting the wrapper and the build instruction into their own files
makes this way easier to maintian.
Ma27
force-pushed
the
refactor-termite-build
branch
from
e9ef19d
to
1f55aaa
Compare
|
good catch @mnacamura! I fixed it in the latest commit 1f55aaa |
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: termite Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: termite Partial log (click to expand)
|
|
@GrahamcOfBorg build termite |
|
Success on x86_64-linux (full log) Attempted: termite Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: termite Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: termite Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Until now it's impossible to override the attrs of the actual build
instruction for the
termitepackage like this:This issue occurs since the
termite/default.nixexpressions returnsthe
symlinkJoinexpression when I override termite (e.g. to provide aconfig file).
I recently patched termite and wanted to apply this patch to my local
termite installation in my system config which is impossible this, so
splitting the wrapper and the build instruction into their own files
makes this way easier to maintian.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)