Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport signal-desktop to stable (18.03) #43678

Merged
merged 10 commits into from Jul 17, 2018

Conversation

primeos
Copy link
Member

@primeos primeos commented Jul 17, 2018

Motivation for this change

According to an IRC discussion the Signal team might regularly break older clients.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

primeos and others added 10 commits July 17, 2018 18:05
(cherry picked from commit 7ec0471)
This isn't a real cherry pick, as I've only applied the changes
affecting Signal (these changes are required to cherry-pick further
commits) and customized the subject to avoid confusion.
(cherry picked from commit 1ac4be3)
(cherry picked from commit 507d24a)
If executed in a pure environment (nix-shell --pure) or depending on the
`gtk3` version of the system Signal-Desktop was e.g. crashing when
clicking on a PDF attachment (instead of showing the dialog to save a
file).
Using wrapGAppsHook and setting XDG_DATA_DIRS to the correct version
fixes this bug.

The error message was the following:
```
(signal-desktop:30756): Gtk-WARNING **: 14:04:49.073: Could not find the icon 'user-home-symbolic-ltr'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
        http://icon-theme.freedesktop.org/releases

(signal-desktop:30756): GLib-GIO-ERROR **: 14:04:49.134: No GSettings schemas are installed on the system
Trace/breakpoint trap
```

(cherry picked from commit 5d79535)
Removed some redundancy (src check via meta.platforms) and made some
changes according to our style-guide.
I've changed meta.description and added meta.longDescription.

(cherry picked from commit ab593d4)
(cherry picked from commit 54ea1cd)
(cherry picked from commit db0da28)
(cherry picked from commit c4d94d6)
(cherry picked from commit c4fca64)
@primeos primeos added the 8.has: port to stable A PR already has a backport to the stable release. label Jul 17, 2018
@primeos primeos self-assigned this Jul 17, 2018
@primeos
Copy link
Member Author

primeos commented Jul 17, 2018

@GrahamcOfBorg eval

@primeos primeos merged commit f9f9657 into NixOS:release-18.03 Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants