New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport signal-desktop to stable (18.03) #43678
Merged
primeos
merged 10 commits into
NixOS:release-18.03
from
primeos:signal-desktop-backport
Jul 17, 2018
Merged
Backport signal-desktop to stable (18.03) #43678
primeos
merged 10 commits into
NixOS:release-18.03
from
primeos:signal-desktop-backport
Jul 17, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7ec0471) This isn't a real cherry pick, as I've only applied the changes affecting Signal (these changes are required to cherry-pick further commits) and customized the subject to avoid confusion.
(cherry picked from commit e1b501a)
(cherry picked from commit 1ac4be3)
(cherry picked from commit 507d24a)
If executed in a pure environment (nix-shell --pure) or depending on the `gtk3` version of the system Signal-Desktop was e.g. crashing when clicking on a PDF attachment (instead of showing the dialog to save a file). Using wrapGAppsHook and setting XDG_DATA_DIRS to the correct version fixes this bug. The error message was the following: ``` (signal-desktop:30756): Gtk-WARNING **: 14:04:49.073: Could not find the icon 'user-home-symbolic-ltr'. The 'hicolor' theme was not found either, perhaps you need to install it. You can get a copy from: http://icon-theme.freedesktop.org/releases (signal-desktop:30756): GLib-GIO-ERROR **: 14:04:49.134: No GSettings schemas are installed on the system Trace/breakpoint trap ``` (cherry picked from commit 5d79535)
Removed some redundancy (src check via meta.platforms) and made some changes according to our style-guide. I've changed meta.description and added meta.longDescription. (cherry picked from commit ab593d4)
(cherry picked from commit 54ea1cd)
(cherry picked from commit db0da28)
(cherry picked from commit c4d94d6)
(cherry picked from commit c4fca64)
primeos
added
the
8.has: port to stable
A PR already has a backport to the stable release.
label
Jul 17, 2018
@GrahamcOfBorg eval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
According to an IRC discussion the Signal team might regularly break older clients.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)