Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups-filters: fix the build with poppler-0.67.0 #44283

Merged
merged 1 commit into from Aug 1, 2018
Merged

cups-filters: fix the build with poppler-0.67.0 #44283

merged 1 commit into from Aug 1, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Aug 1, 2018 •
edited

Motivation for this change

Apply the patch from OpenPrinting/cups-filters#51 to fix the build of cups-filter originally broken by 7d01650.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

closes #44282

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@GrahamcOfBorg build cups-filters system-config-printer

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: cups-filters, system-config-printer

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: cups-filters, system-config-printer

Partial log (click to expand)

trying https://github.com/OpenPrinting/cups-filters/commit/219de01c61f3b1ec146abf142d0dfc8c560cc58e.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   814    0   814    0     0   2071      0 --:--:-- --:--:-- --:--:--  2071
fixed-output derivation produced path '/nix/store/8lsqp42m40sc1sdvhicqkmpngxvk2bg6-219de01c61f3b1ec146abf142d0dfc8c560cc58e.patch' with sha256 hash '0f0lql3rbm2g8mxrpigfyi8fb4i2g4av20g417jzdilp60jq0ny8' instead of the expected hash '0i503z6qa4m07qiaxfy81fpj9ybnswp7dkja2amv6m2n9pk45qqj'
cannot build derivation '/nix/store/1ghmmbdzfsw152qzx7b0q1v9hzaj44gj-cups-filters-1.20.4.drv': 1 dependencies couldn't be built
copying path '/nix/store/7xinm3hzili33mnq8609qrirv3g261ag-samba-4.7.6' from 'https://cache.nixos.org'...
copying path '/nix/store/ifbg4dawi1jwq0r3siqlmlgbif8r2y8h-python3.6-pysmbc-1.0.15.8' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/bwiixqijkxldwkpfqbg5qdx35nfs8737-system-config-printer-1.5.11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/1ghmmbdzfsw152qzx7b0q1v9hzaj44gj-cups-filters-1.20.4.drv', '/nix/store/bwiixqijkxldwkpfqbg5qdx35nfs8737-system-config-printer-1.5.11.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: cups-filters, system-config-printer

Partial log (click to expand)

  File "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/lib/python3.6/wsgiref/simple_server.py", line 133, in handle
    handler.run(self.server.get_app())
  File "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/lib/python3.6/wsgiref/handlers.py", line 144, in run
    self.close()
  File "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/lib/python3.6/wsgiref/simple_server.py", line 35, in close
    self.status.split(' ',1)[0], self.bytes_sent
AttributeError: 'NoneType' object has no attribute 'split'
part1part2
cannot build derivation '/nix/store/ayb0v4z5jydm39src0h6vcnxiwn6hgmk-system-config-printer-1.5.11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4jyl94k7l5k9s4152axk8jj9fzck4az0-cups-filters-1.20.4.drv', '/nix/store/ayb0v4z5jydm39src0h6vcnxiwn6hgmk-system-config-printer-1.5.11.drv' failed

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

hash mismatch of the patch.

@kalbasit
Copy link
Member Author

kalbasit commented Aug 1, 2018 •
edited

@xeji I fixed the hash, please rebuild. Sorry about that.

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

That was fast 😃
@GrahamcOfBorg build cups-filters system-config-printer

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: cups-filters, system-config-printer

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cups-filters, system-config-printer

Partial log (click to expand)

/nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11/share/system-config-printer/check-device-ids.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/bin/python3"
/nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11/share/system-config-printer/pysmb.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/bin/python3"
/nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11/share/system-config-printer/scp-dbus-service.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/bin/python3"
/nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11/share/system-config-printer/system-config-printer.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/bin/python3"
/nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11/share/system-config-printer/install-printerdriver.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/bin/python3"
/nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11/share/system-config-printer/applet.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/bin/python3"
/nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11/share/system-config-printer/troubleshoot/__init__.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11...
/nix/store/6v26pqp2xr4hj1pxa7wwj8w4hyzyqhif-cups-filters-1.20.4
/nix/store/9qcf8a4wdvhayv2dywwpak01b593x7a4-system-config-printer-1.5.11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cups-filters, system-config-printer

Partial log (click to expand)

/nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11/share/system-config-printer/troubleshoot/__init__.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/8wfgl06xbcsxs6pmwr3n04kyhnvsh31d-python3-3.6.6/bin/python3"
/nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11/share/system-config-printer/pysmb.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/8wfgl06xbcsxs6pmwr3n04kyhnvsh31d-python3-3.6.6/bin/python3"
/nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11/bin/.install-printerdriver-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11/bin/.system-config-printer-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11/bin/.system-config-printer-applet-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11/bin/.scp-dbus-service-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11/etc/udev/udev-add-printer: interpreter directive changed from "/usr/bin/python3 -sB" to "/nix/store/8wfgl06xbcsxs6pmwr3n04kyhnvsh31d-python3-3.6.6/bin/python3 -sB"
checking for references to /build in /nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11...
/nix/store/fbl03vnkcdvkq4ad216mq3amvh51lyz6-cups-filters-1.20.4
/nix/store/lsmhnj70420bksvnqj5k9hpq21ihljfc-system-config-printer-1.5.11

@xeji xeji merged commit d7c34de into NixOS:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cups-filters: broken build from poppler_utils update
3 participants
@kalbasit @xeji @GrahamcOfBorg