Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/tests: Add test for LD_LIBRARY_PATH #44301

Merged
merged 1 commit into from Aug 1, 2018
Merged

pkgs/tests: Add test for LD_LIBRARY_PATH #44301

merged 1 commit into from Aug 1, 2018

Conversation

dezgeg
Copy link
Contributor

@dezgeg dezgeg commented Aug 1, 2018

The latest binutils upgrade silently broke this until it was fixed by
#43531.

So add a test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dezgeg
pkgs/tests: Add test for LD_LIBRARY_PATH
e98a414 
The latest binutils upgrade silently broke this until it was fixed by
NixOS#43531.

So add a test.
@dezgeg dezgeg mentioned this pull request Aug 1, 2018
Merged
9 tasks
@dezgeg dezgeg merged commit e94fcbc into NixOS:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dezgeg @GrahamcOfBorg