Fix Dir.glob to list broken symlinks (#6466)

crystal-lang · Aug 1, 2018 · 9cce189 · 9cce189
1 parent 939a81b
commit 9cce189
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/spec/std/dir_spec.cr b/spec/std/dir_spec.cr
@@ -261,6 +261,7 @@ describe "Dir" do
           datapath("f1_link.txt"),
           datapath("non_link.txt"),
         ].sort
+        Dir["#{datapath}/non_link.txt"].should eq [datapath("non_link.txt")]
       ensure
         File.delete link
         File.delete non_link

diff --git a/src/dir/glob.cr b/src/dir/glob.cr
@@ -182,7 +182,7 @@ class Dir
         when ConstantEntry
           return if sequence[pos + 1]?.is_a?(RecursiveDirectories)
           full = join(path, cmd.path)
-          yield full if File.exists?(full)
+          yield full if File.exists?(full) || File.symlink?(full)
         when ConstantDirectory
           path_stack << {next_pos, join(path, cmd.path)}
           # Don't check if full exists. It just costs us time