Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdbm: 1.15 -> 1.17 #44296

Merged
merged 1 commit into from Aug 1, 2018
Merged

gdbm: 1.15 -> 1.17 #44296

merged 1 commit into from Aug 1, 2018

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 1, 2018

Motivation for this change

See release informatinos:

This MR is for staging (mass rebuild)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gdbm

Partial log (click to expand)

shrinking /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17/lib/libgdbm_compat.so.4.0.0
shrinking /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17/lib/libgdbm.so.6.0.0
shrinking /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17/bin/gdbm_load
shrinking /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17/bin/gdbmtool
shrinking /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17/bin/gdbm_dump
gzipping man pages under /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17/lib  /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17/bin
patching script interpreter paths in /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17
checking for references to /build in /nix/store/galny2lv9jc84knfr9vaz70wp1zs86qj-gdbm-1.17...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gdbm

Partial log (click to expand)

shrinking /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17/bin/gdbm_load
shrinking /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17/bin/gdbmtool
shrinking /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17/lib/libgdbm_compat.so.4.0.0
shrinking /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17/lib/libgdbm.so.6.0.0
gzipping man pages under /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17/share/man/
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17/lib  /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17/bin
patching script interpreter paths in /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17
checking for references to /build in /nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17...
/nix/store/p9srgm8kp92sq094chsyh07bvspsz60j-gdbm-1.17

@Mic92
Copy link
Member

Mic92 commented Aug 1, 2018

1.17 changes the public api slightly (void -> int), but this is not so likely to break something.

@Mic92 Mic92 merged commit a1fc74b into NixOS:staging Aug 1, 2018
@vcunat
Copy link
Member

vcunat commented Aug 10, 2018

That's probably the problem on darwin:

error: non-void function 'gdbm_sync' should return a value

@vcunat
Copy link
Member

vcunat commented Aug 10, 2018 •
edited

It's actually a portable mistake in the code, only on Linux the warning is not fatal (not sure why).

EDIT: upstream has bugfixes for this and another problem on master http://git.gnu.org.ua/cgit/gdbm.git/log/

@vcunat
Copy link
Member

vcunat commented Aug 10, 2018

#44875

@lsix lsix deleted the gdbm-1-17 branch August 22, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lsix @GrahamcOfBorg @Mic92 @vcunat