Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipmenu: init at 5.4.0 #43494

Merged
merged 2 commits into from Jul 15, 2018
Merged

clipmenu: init at 5.4.0 #43494

merged 2 commits into from Jul 15, 2018

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Jul 13, 2018

Motivation for this change

clipmenu is a tool for managing your clipboard with dmenu. see https://github.com/cdown/clipmenu

also add a nixos systemd user module for running clipmenud

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [xd] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: clipmenu

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0/bin
patching script interpreter paths in /nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0
/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0/bin/.clipmenud-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0/bin/.clipmenu-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0/bin/.clipdel-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0...
/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: clipmenu

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/1sh16plcflkdyksv41yv53cqsj8pn5ly-clipmenu-5.4.0/bin
patching script interpreter paths in /nix/store/1sh16plcflkdyksv41yv53cqsj8pn5ly-clipmenu-5.4.0
/nix/store/1sh16plcflkdyksv41yv53cqsj8pn5ly-clipmenu-5.4.0/bin/.clipdel-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash"
/nix/store/1sh16plcflkdyksv41yv53cqsj8pn5ly-clipmenu-5.4.0/bin/.clipmenu-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash"
/nix/store/1sh16plcflkdyksv41yv53cqsj8pn5ly-clipmenu-5.4.0/bin/.clipmenud-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash"
/nix/store/1sh16plcflkdyksv41yv53cqsj8pn5ly-clipmenu-5.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: clipmenu

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin
patching script interpreter paths in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipmenu-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipmenud-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipdel-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0...
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0

xeji
xeji reviewed Jul 14, 2018
View reviewed changes
pkgs/applications/misc/clipmenu/default.nix Outdated
@@ -0,0 +1,34 @@
{ clipnotify, makeWrapper, xsel, dmenu2, utillinux, gawk, stdenv, fetchFromGitHub, lib }:
let
makeBinPath = pkgs: lib.concatStringsSep ":" (map (pkg: "${lib.getBin pkg}/bin") pkgs);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why write this yourself? Please use lib.makeBinPath instead.

@jb55
Copy link
Contributor Author

jb55 commented Jul 15, 2018 via email

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: clipmenu

Partial log (click to expand)

/nix/store/1sh16plcflkdyksv41yv53cqsj8pn5ly-clipmenu-5.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: clipmenu

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0/bin
patching script interpreter paths in /nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0
/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0/bin/.clipmenud-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0/bin/.clipmenu-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0/bin/.clipdel-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0...
/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: clipmenu

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin
patching script interpreter paths in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipmenu-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipmenud-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipdel-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0...
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0

xeji
xeji reviewed Jul 15, 2018
View reviewed changes
nixos/modules/services/misc/clipmenu.nix Outdated
description = "clipmenu derivation to use.";
};

install = mkOption {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this option's value has no effect at all. This is probably not what you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yeah I copied it over from another module, fixing

jb55 added 2 commits July 15, 2018 12:22
@jb55
clipmenu: init at 5.4.0
fb13087 
clipmenu is a simple tool for managing you clipboard with dmenu.
@jb55
nixos/modules: add clipmenu user service
6c1eb15 
add a clipmenud daemon user service
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: clipmenu

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin 
patching script interpreter paths in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipmenud-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipmenu-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0/bin/.clipdel-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /tmp/nix-build-clipmenu-5.4.0.drv-0 in /nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0...
/nix/store/mf4p5lx7yj39m20xbiy965bnawkdm461-clipmenu-5.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: clipmenu

Partial log (click to expand)

/nix/store/9pial04agjn8wh9jh9s4j56d8mh404n1-clipmenu-5.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: clipmenu

Partial log (click to expand)

/nix/store/1sh16plcflkdyksv41yv53cqsj8pn5ly-clipmenu-5.4.0

@xeji xeji merged commit 311f017 into NixOS:master Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jb55 @GrahamcOfBorg @xeji