Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform_0_11: 0.11.7 -> 0.11.8 #45117

Merged
merged 1 commit into from Aug 16, 2018
Merged

terraform_0_11: 0.11.7 -> 0.11.8 #45117

merged 1 commit into from Aug 16, 2018

Conversation

stephengroat
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Aug 16, 2018
View reviewed changes
pkgs/applications/networking/cluster/terraform/default.nix
version = "0.11.7";
sha256 = "0q5gl8yn1f8fas1v68lz081k88gbmlk7f2xqlwqmh01qpqjxd42q";
version = "0.11.8";
sha256 = "1kdmx21l32vj5kvkimkx0s5mxgmgkdwlgbin4f3iqjflzip0cddh";
patches = [ ./provider-path.patch ];
passthru = { inherit plugins; };
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zimbatm what versions of terraform do we want in nixpkgs? Does upstream provide support for older versions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform seems to only release incrementally. Once 0.11 was out they only published TINY releases for 0.11. In general they are pretty good with backward-compatibility in TINY releases so one per MAJOR.MINOR should be ok.

After that we should limit the number of concurrent versions where N~=2 to make migrations easier. Some times it's not possible because for example terragrunt was depending on an old release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reported by upstream: hashicorp/terraform#15178 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to know. I already started to see plugins complaining about protocol versions so we'll probably drop 0.11 soon.

@zimbatm
Copy link
Member

zimbatm commented Aug 16, 2018

@GrahamcOfBorg build terraform_0_11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: terraform_0_11

Partial log (click to expand)

github.com/hashicorp/terraform/tools/terraform-bundle
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7b0lykfjb7p7zqv5mnl7hb4aw6b4nh8q-terraform-0.11.8-bin
shrinking /nix/store/7b0lykfjb7p7zqv5mnl7hb4aw6b4nh8q-terraform-0.11.8-bin/bin/terraform
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7b0lykfjb7p7zqv5mnl7hb4aw6b4nh8q-terraform-0.11.8-bin/bin
patching script interpreter paths in /nix/store/7b0lykfjb7p7zqv5mnl7hb4aw6b4nh8q-terraform-0.11.8-bin
checking for references to /build in /nix/store/7b0lykfjb7p7zqv5mnl7hb4aw6b4nh8q-terraform-0.11.8-bin...
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: terraform_0_11

Partial log (click to expand)

github.com/hashicorp/terraform/vendor/github.com/hashicorp/go-getter
github.com/hashicorp/terraform/plugin/discovery
github.com/hashicorp/terraform/moduledeps
github.com/hashicorp/terraform/config
github.com/hashicorp/terraform/config/module
github.com/hashicorp/terraform/terraform
github.com/hashicorp/terraform/plugin
github.com/hashicorp/terraform/tools/terraform-bundle
builder for '/nix/store/15nj1f41c96bakvqrvnxglpk65a3w1yh-terraform-0.11.8.drv' failed with exit code 44
error: build of '/nix/store/15nj1f41c96bakvqrvnxglpk65a3w1yh-terraform-0.11.8.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: terraform_0_11

Partial log (click to expand)

find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
find: '/nix/store/lk3q1yql3fnlaa883vv2hqjd18fq4wmm-terraform-0.11.8': No such file or directory
/nix/store/yygnabsrb6z653n0dc2pyjs9r4w19mlw-terraform-0.11.8-bin

@zimbatm zimbatm merged commit c218a9c into NixOS:master Aug 16, 2018
@stephengroat stephengroat deleted the patch-1 branch August 16, 2018 20:19
@Mic92 Mic92 mentioned this pull request Aug 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephengroat @zimbatm @GrahamcOfBorg @Mic92