Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strace: 4.23 -> 4.24 #45115

Merged
merged 1 commit into from Aug 16, 2018
Merged

strace: 4.23 -> 4.24 #45115

merged 1 commit into from Aug 16, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 16, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: strace

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: strace

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24
shrinking /nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24/bin/strace
gzipping man pages under /nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24/bin
patching script interpreter paths in /nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24
/nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/mbmf1j17gadvxi9rrr8rzj0iqnb8xxyp-perl-5.24.4/bin/perl"
/nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24...
/nix/store/k5lp7l5w547lc1d3c1713mlj9516drq3-strace-4.24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: strace

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24
shrinking /nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24/bin/strace
gzipping man pages under /nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24/share/man/
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24/bin
patching script interpreter paths in /nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24
/nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/zkw0jd6fnsm56zsb4w68d11vvgg9s4ns-perl-5.24.4/bin/perl"
checking for references to /build in /nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24...
/nix/store/0nyzc16a79rmggnddgjb1i8k4qibr73x-strace-4.24

@Mic92 Mic92 merged commit c4dbfa0 into NixOS:master Aug 16, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Aug 16, 2018

For some archs it might be significantly better to use libdw (elfutils) instead of libunwind. The mailing lists have some numbers IIRC, if you search for them. Haven't found information on what is preferred but I believe it uses libdw if both are provided (but that might not be significant). Maybe that's the way to go on ELF-oriented platforms. Anyone know?

As an aside it seems libiberty or so is needed for demangling, too.

@dtzWill
Copy link
Member Author

dtzWill commented Aug 16, 2018

(I believe all of this is true of previous version at least but might be worth investigating...)

@Mic92
Copy link
Member

Mic92 commented Aug 16, 2018

What architectures are we talking about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @Mic92