Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flash: 30.0.0.134 -> 30.0.0.154 #45100

Merged
merged 1 commit into from Aug 16, 2018
Merged

flash: 30.0.0.134 -> 30.0.0.154 #45100

merged 1 commit into from Aug 16, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Aug 16, 2018 •
edited

Motivation for this change

older flash is 404!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Built:

  • nix-build -I nixpkgs=. -A pkgs.flashplayer
  • nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer
  • nix-build -I nixpkgs=. -E "(import {}).flashplayer.override { debug = true; }"
  • nix-build -I nixpkgs=. -E "(import {}).pkgsi686Linux.flashplayer.override { debug = true; }"
  • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone
  • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger
  • nix-build -I nixpkgs=. -E "(import {}).chromium.override { enablePepperFlash = true; }"

@kalbasit
Copy link
Member Author

kalbasit commented Aug 16, 2018 •
edited

@GrahamcOfBorg build pkgs.flashplayer pkgsi686Linux.flashplayer pkgs.flashplayer-standalone pkgs.flashplayer-standalone-debugger

EDIT: ofborg does not build unfree?

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: pkgs.flashplayer, pkgsi686Linux.flashplayer, pkgs.flashplayer-standalone, pkgs.flashplayer-standalone-debugger

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: pkgs.flashplayer, pkgsi686Linux.flashplayer, pkgs.flashplayer-standalone, pkgs.flashplayer-standalone-debugger

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: pkgs.flashplayer, pkgsi686Linux.flashplayer, pkgs.flashplayer-standalone, pkgs.flashplayer-standalone-debugger

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: pkgs.flashplayer, pkgsi686Linux.flashplayer, pkgs.flashplayer-standalone, pkgs.flashplayer-standalone-debugger

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92 Mic92 merged commit d80fb9a into NixOS:master Aug 16, 2018
@Mic92
Copy link
Member

Mic92 commented Aug 16, 2018

I suppose this needs a backport?

@kalbasit
Copy link
Member Author

@Mic92 definitely, since the build will 404. I wish they would stop removing their old files! Should we host them somewhere ourselves?

@kalbasit kalbasit deleted the update-flash branch August 16, 2018 15:04
@Mic92
Copy link
Member

Mic92 commented Aug 17, 2018

one can mirror on archive.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @GrahamcOfBorg @Mic92