lightdm: enable the accounts daemon to find dbus interface #45107
Conversation
mnacamura
changed the title
| @@ -212,6 +212,10 @@ in | |||
| # lightdm uses the accounts daemon to rember language/window-manager per user | |||
| services.accounts-daemon.enable = true; | |||
|
|
|||
| # Enable the accounts daemon to find lightdm's dbus interface | |||
| environment.pathsToLink = [ "/share/accountsservice" ]; | |||
There was a problem hiding this comment.
I think this should go to accountsservice.nix. There might be other extensions than lightdm.
|
|
||
| wantedBy = [ "graphical.target" ]; | ||
|
|
||
| } // (mkIf (!config.users.mutableUsers) { | ||
| # Accounts daemon looks for dbus interfaces in $XDG_DATA_DIRS/accountsservice | ||
| environment.XDG_DATA_DIRS = "/run/current-system/sw/share"; |
There was a problem hiding this comment.
I think something like ${config.system.path}/share should be better.
There was a problem hiding this comment.
Done. Thank you for your review!
There was a problem hiding this comment.
Hm, shouldn't systemd system services run in an environment that has XDG_DATA_DIRS set appropriately for the current system? I'm surprised more things don't break if that not true.
There was a problem hiding this comment.
The variables are often set by login shell, so the services cannot see them. It is probably good thing, as the unclean environment could produce unpredictable behaviour.
mnacamura
force-pushed
the
lightdm-accountsservice
branch
from
c4f4167
to
7fbdd7f
Compare
|
Looks great, thanks. |
Motivation for this change
Fix #45059
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)