Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/triggerhappy: add module for triggerhappy hotkey daemon #45109

Merged
merged 2 commits into from Oct 8, 2018
Merged

nixos/triggerhappy: add module for triggerhappy hotkey daemon #45109

merged 2 commits into from Oct 8, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

While actkbd is quite similar and we already have a NixOS module for it, triggerhappy allows specifiying keys by their names instead of keycodes which is much simpler. It is equally light and needs only one process for all input devices as new devices are added using an udev rule and announcing them to the triggerhappy daemon.

Things done

The new triggerhappy module is based on the actkbd module.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @taha

@matthewbauer
Copy link
Member

@GrahamcOfBorg build triggerhappy

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: triggerhappy

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hqxap8x9y8mn54x6i7rs4m2xpl0rdnh5-triggerhappy-0.5.0
shrinking /nix/store/hqxap8x9y8mn54x6i7rs4m2xpl0rdnh5-triggerhappy-0.5.0/bin/th-cmd
shrinking /nix/store/hqxap8x9y8mn54x6i7rs4m2xpl0rdnh5-triggerhappy-0.5.0/bin/thd
gzipping man pages under /nix/store/hqxap8x9y8mn54x6i7rs4m2xpl0rdnh5-triggerhappy-0.5.0/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hqxap8x9y8mn54x6i7rs4m2xpl0rdnh5-triggerhappy-0.5.0/bin
patching script interpreter paths in /nix/store/hqxap8x9y8mn54x6i7rs4m2xpl0rdnh5-triggerhappy-0.5.0
checking for references to /build in /nix/store/hqxap8x9y8mn54x6i7rs4m2xpl0rdnh5-triggerhappy-0.5.0...
/nix/store/hqxap8x9y8mn54x6i7rs4m2xpl0rdnh5-triggerhappy-0.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: triggerhappy

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kqlkn85f312kklnppvx21spkl5kg6zx6-triggerhappy-0.5.0
shrinking /nix/store/kqlkn85f312kklnppvx21spkl5kg6zx6-triggerhappy-0.5.0/bin/th-cmd
shrinking /nix/store/kqlkn85f312kklnppvx21spkl5kg6zx6-triggerhappy-0.5.0/bin/thd
gzipping man pages under /nix/store/kqlkn85f312kklnppvx21spkl5kg6zx6-triggerhappy-0.5.0/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kqlkn85f312kklnppvx21spkl5kg6zx6-triggerhappy-0.5.0/bin
patching script interpreter paths in /nix/store/kqlkn85f312kklnppvx21spkl5kg6zx6-triggerhappy-0.5.0
checking for references to /build in /nix/store/kqlkn85f312kklnppvx21spkl5kg6zx6-triggerhappy-0.5.0...
/nix/store/kqlkn85f312kklnppvx21spkl5kg6zx6-triggerhappy-0.5.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: triggerhappy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@matthewbauer matthewbauer merged commit dd6f695 into NixOS:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @matthewbauer @GrahamcOfBorg