protonmail-bridge - add warning in description about enabling gnome-keyring #45108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Aug 16, 2018
| and decrypts your mail as it enters and leaves your computer | ||
| and decrypts your mail as it enters and leaves your computer. | ||
|
|
||
| To work, gnome-keyring service must be enabled. See https://github.com/NixOS/nixpkgs/issues/45070 for details. |
There was a problem hiding this comment.
Is it possible to briefly summarize the details instead of adding a link?
There was a problem hiding this comment.
I can just delete the link. As far as I understand, the gnome-keyring must be enabled and that's it...
karolchmist
force-pushed
the
protonmail-bridge-description-gnome-keyring
branch
from
a061f5c
to
9058c04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As a follop up of the issue #45070, this PR adds an important information about enabling gnome-keyring service for protonmail-bridge to work.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)