Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 7bfb3e163e8a
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 1fd75a100308
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 16, 2018

  1. sqldeveloper: simplify, add darwin support 

    Use unpackCmd and installPhase instead of overwriting buildCommand.
This makes the derivation more readable, and adds binary stripping and
shebang patching of the output as a bonus :-)

Use makeWrapper instead of a custom wrapper script, and only export
environment variables that are used.

Set JAVA_HOME to ${jdk.home}, making it more generic and independent of
the specific jdk path being used (was a different one on zulu). This
fixes sqldeveloper on darwin, so add it to supported platforms
(plus the known-working x86_64-linux)
    @flokli
    flokli committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    29503b1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #45110 from flokli/sqldeveloper 

    sqldeveloper: simplify, add darwin support
    @Mic92
    Mic92 committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    1fd75a1 View commit details
    Browse the repository at this point in the history