Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splix: install color profiles and enable JBIG #45111

Merged
merged 1 commit into from Aug 16, 2018
Merged

splix: install color profiles and enable JBIG #45111

merged 1 commit into from Aug 16, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Compatibility with color printers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @peti @abbradar @husnoo @emmanuelrosa

Mic92
Mic92 reviewed Aug 16, 2018
View reviewed changes
pkgs/misc/cups/drivers/splix/default.nix Outdated

meta = {
homepage = http://splix.sourceforge.net;
description = "CUPS drivers for SPL (Samsung Printer Language) printers";
homepage = http://splix.ap2c.org;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a license while you are at it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Didn't notice that before.

@Mic92
Copy link
Member

Mic92 commented Aug 16, 2018

@GrahamcOfBorg build splix

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: splix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: splix

Partial log (click to expand)


post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5y023jqmsr502xa1ady025j9nr77p6qc-splix-svn-315
shrinking /nix/store/5y023jqmsr502xa1ady025j9nr77p6qc-splix-svn-315/lib/cups/filter/pstoqpdl
shrinking /nix/store/5y023jqmsr502xa1ady025j9nr77p6qc-splix-svn-315/lib/cups/filter/rastertoqpdl
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5y023jqmsr502xa1ady025j9nr77p6qc-splix-svn-315/lib
patching script interpreter paths in /nix/store/5y023jqmsr502xa1ady025j9nr77p6qc-splix-svn-315
checking for references to /build in /nix/store/5y023jqmsr502xa1ady025j9nr77p6qc-splix-svn-315...
/nix/store/5y023jqmsr502xa1ady025j9nr77p6qc-splix-svn-315

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: splix

Partial log (click to expand)


post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/abgqrqn2g01v9wbzwvmcqs7zy9ny7dnq-splix-svn-315
shrinking /nix/store/abgqrqn2g01v9wbzwvmcqs7zy9ny7dnq-splix-svn-315/lib/cups/filter/pstoqpdl
shrinking /nix/store/abgqrqn2g01v9wbzwvmcqs7zy9ny7dnq-splix-svn-315/lib/cups/filter/rastertoqpdl
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/abgqrqn2g01v9wbzwvmcqs7zy9ny7dnq-splix-svn-315/lib
patching script interpreter paths in /nix/store/abgqrqn2g01v9wbzwvmcqs7zy9ny7dnq-splix-svn-315
checking for references to /build in /nix/store/abgqrqn2g01v9wbzwvmcqs7zy9ny7dnq-splix-svn-315...
/nix/store/abgqrqn2g01v9wbzwvmcqs7zy9ny7dnq-splix-svn-315

@Mic92 Mic92 merged commit 5021944 into NixOS:master Aug 16, 2018
@jfrankenau jfrankenau deleted the splix-color-profiles branch August 16, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @Mic92 @GrahamcOfBorg